maxzinkus / atypicalspeech

👋 Hi, I’m @maxzinkus

I am a:

• 🎓 PhD Candidate in Computer Science at Johns Hopkins University
• 📚 Published research author (Google Scholar) in venues such as Usenix Security, PETS, IACR TCC, and ACM SIGCSE
• 🛠️ Software/Security/Cryptography Engineer with experience building and breaking secure systems

Thanks for visiting! If you're interested in my work here or anywhere else, feel free to drop me a line via my personal site:

• 🌐 https://mzink.us

atypicalspeech's Issues

Download all audios in a zip

Attach archive-storage data push to "Upload" button

For storing data in azure long-term storage

Enable SameSite='Strict'

AtypicalSpeech/controllers/auth/auth.ctrl.js

Line 86 in e16e1e9

sameSite: 'none',

Strict samesite restrictions is appropriate as our app is not meant to be embedded or cross-functional with other websites.

Doesn't reset the process when restart recording

Add two-factor TOTP authentication to admin login

Passwords are often not a sufficient protection against unauthorized login. Adding time-based OTP (TOTP) using a standard node.js library and pairing it with an app such as Google Authenticator or Microsoft Authenticator on admin's personal devices (i.e. smartphones) would dramatically improve security.

Test Micro before recording

New Audio Recorder

Require adminAuth on all admin-related controllers

As discussed in Zoom, require authentication in all api points.

Branch change-recorder merge into alpha

BE - reset all the routers under /api

Audio Distortion

Audio recordings made with distortions - sample recordings with distortions

The issue seems to be happening for a couple of other users of the 'audio-react-recorder' library. Link to issue

Depends on the device, but on the device currently deployed at the hospital, distortion starts to happen around the 7th or 8th consecutive recording with the distortion worsening afterwards.

I have tried modifying audio settings of audio-react-recorder (ex) and have attempted changing audio formats but have not been able to produce any meaningful improvement in audio quality.

'audio-react-recorder' does seem to be an abandoned library; have also explored other libraries as a last resort (ex). Please let me know if you have any recommendations on switching to another recording library, or potentially build one ourselves (expensive, though).

Admin Pages 404

Seems like the version being built are the same between development and prod mode, so the issue should be addressed at the router can't route to the right page

Add logout button

As discussed in Zoom, add a logout button to the admin which invalidates the JWT on the server-side and deletes the cookie from the client.

logs make irresponsible

Welcome Page Reconstruct

Page:

Code:

intuition:
Reconstruct the Welcome Page with a straightforward HTML structure to extend more easily later in the future

FE - first sentence shouldn't show up before recording

Compiling Error

Scenario:

There is an error happened while we try to deploy our production code to the server, here is the error as below:
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR!   react@"^18.2.0" from the root project
npm ERR!   peer react@">=16.8.0" from @emotion/[email protected]
npm ERR!   node_modules/@emotion/react
npm ERR!     @emotion/react@"^11.10.5" from the root project
npm ERR!     peer @emotion/react@"^11.0.0-rc.0" from @emotion/[email protected]
npm ERR!     node_modules/@emotion/styled
npm ERR!       @emotion/styled@"^11.10.5" from the root project
npm ERR!       3 more (@mui/material, @mui/styled-engine, @mui/system)
npm ERR!     3 more (@mui/material, @mui/styled-engine, @mui/system)
npm ERR!   20 more (@emotion/styled, ...)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.0.0" from [email protected]
npm ERR! node_modules/audio-react-recorder
npm ERR!   audio-react-recorder@"^1.0.4" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/react
npm ERR!   peer react@"^16.0.0" from [email protected]
npm ERR!   node_modules/audio-react-recorder
npm ERR!     audio-react-recorder@"^1.0.4" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /home/runner/.npm/_logs/2023-05-16T19_56_23_565Z-eresolve-report.txt

Issue Address:
When deploying, the script in deploy.yml will be run, and the crash happens in the code I've stressed:

The reason is when we're using npm version 7+, it adds a new feature named "peer dependency", which analyzes the shared libraries like react and react-dom in each third-party plugin whether are using the same version or a permitted version.

Solution:
In package.json, we add this rule as follows, and it will force third-party plugins to use the same version of shared libraries and avoid installing repeated ones again and again.

FYI:
--force and --legacy-peer-deps are also temporary solutions to help to deploy not blocking the whole process, but it's definitely not an ideal way to use in a production environment.

References:
https://medium.com/@reemshakes/devdependencies-vs-dependencies-in-reactjs-db7261e13012
https://jsramblings.com/do-dependencies-devdependencies-matter-when-using-webpack/
https://stackoverflow.com/questions/66020820/npm-when-to-use-force-and-legacy-peer-deps
https://developer.aliyun.com/article/1060855

JWT Credential in git history

AtypicalSpeech/config/jwt.json

Line 2 in e16e1e9

"jwtSecret": "35d3331f40dac9c738ab5b9f0ed745adf7a126b218b0dc477d0a006e1914640f423d0e"

Similarly, this should be purged and changed.

Fe - When completed recording, didn't redirect to dashboard

Credentials in git

AtypicalSpeech/config/config.json

Line 18 in e16e1e9

"password": "database_speech",

This file should not be tracked in git. Credentials in the git history should be changed once they can be purged.

Node - api of uploading audios

Read database credentials from Environment Variables

AtypicalSpeech/database.js

Line 3 in e16e1e9

const sequelize = new Sequelize('database_speech', 'database_speech', 'database_speech', {

Even though our database is only locally accessible, it's generally considered far more secure to read credentials from secure storage or at least from the environment. This way, we don't have credentials in the git history. Once this change is adopted, the credentials can be updated.

SE - configurate api request to the Node in Nginx

Signal Indicator

The thing is that as users can have several microphones in their system, it could happen that no mic is selected (or a silent source is selected) and the person will not be recording any audio. It will still generate a file, but it will be just silence. I think we should have some type of signal indicator (waveform, vu-meter, whatever)

Testing - Mysql Database

Lost Process when refreshing

PRD - Admin Prototype

Solution:
https://wzuuw.sse.codesandbox.io/#/table/inline-edit-table
https://pro.ant.design/docs/getting-started

Login Page:

Management Page:

User Center Module:

User List Module:

Script List Module:

Script Upload Module:
TBD, involving the storage system, the most challenging and time-consuming section to work on, things will be different when we upload scripts to the server.

Too many errors in the Console

BE - vulnerabilities in node modules

App(Node)

After fixed: from 23(3 high) to 6(moderate)

Client

from

to:

react-scripts is the official library of react.js, although it contains vulnerabilities, it's still trustworthy.

Fix Recording Existing Issues

SE - Makes node.js running

PRD - Dashboard Prototype

DataFlow Diagram:

Todo List:
Need to make it into a user interface prototype, then figure out what modules should be done.