project-1's Issues
Project #1 Feedback
Hey Max, I hope you are having a great day!
Great job on your HTML. It's well formatted and you did a great job using rows and columns as well as HTML5 semantic tags for each <section>
.
As far as your CSS goes, section:first-child, section:nth-child(2)
- I'd be slightly wary of using complex selectors to identify elements when a class or an ID would be better. It's not a problem for now, but later on it can be important to think about the intention your code is communicating just as much as having it work in one specific scenario. nth-child(2)
might cause undesired effects if future-you or someone else decides to add another <section>
element. It would be quite a surprise when the whole page suddenly breaks.
I like to say CSS is like writing laws. Sometimes a law might work for a situation, but when writing it you should also think about how it could go wrong or be misinterpreted and save yourself some pain in the future.
Your Javascript looks fantastic. You are creating not one but two classes - great job! I love that you are passing selectors into functions versus binding the functions to the view. You have created very re-usable code here. I might suggest trying to weed out those last few "floating-around" functions; namely: removeTabItem
, updateItemPrice
, and toggleHidden
. You should try to find them a home inside of an appropriate object.
Great Job!
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.