maxrpeterson / project-1 Goto Github PK

Hey Max, I hope you are having a great day!

Great job on your HTML. It's well formatted and you did a great job using rows and columns as well as HTML5 semantic tags for each <section>.

As far as your CSS goes, section:first-child, section:nth-child(2) - I'd be slightly wary of using complex selectors to identify elements when a class or an ID would be better. It's not a problem for now, but later on it can be important to think about the intention your code is communicating just as much as having it work in one specific scenario. nth-child(2) might cause undesired effects if future-you or someone else decides to add another <section> element. It would be quite a surprise when the whole page suddenly breaks.

I like to say CSS is like writing laws. Sometimes a law might work for a situation, but when writing it you should also think about how it could go wrong or be misinterpreted and save yourself some pain in the future.

Your Javascript looks fantastic. You are creating not one but two classes - great job! I love that you are passing selectors into functions versus binding the functions to the view. You have created very re-usable code here. I might suggest trying to weed out those last few "floating-around" functions; namely: removeTabItem, updateItemPrice, and toggleHidden. You should try to find them a home inside of an appropriate object.

Great Job!