Comments (9)
Hi @zetaab!
The Jira ticket for the PR you referenced has been re-opened as it needs some additional fixing, so I added a note in it about the bug you are seeing: https://mattermost.atlassian.net/browse/MM-10621.
I'll create a new ticket for this if our devs determine that it should be fixed separately.
from mattermost-redux.
@zetaab That's weird. I can't see how it's being passed as postId instead of locale in sortFileInfos. You'll notice that the said locale is a props of CreatePost and CreateComment which is basically from the selector getCurrentLocale.
Are you using the release version of 5.2?
If possible, could you give a repro steps/files for these?
Thanks for the report!
from mattermost-redux.
I tried to reproduce it myself as well, but I could not. Anyways the key thing is to upload many files at the same time. At least two files should have same timestamp.
The json for files is
[{"id":"83nry87b8trfudogkjt71344dw","user_id":"8fa9tyyk7jymzgbemhuy6ert9w","post_id":"ngkaqozwqtdtxgeykwsc84y11r","create_at":1535459022330,"update_at":1535459022330,"delete_at":0,"name":"Näyttökuva 2018-08-28 kello 15.19.20.png","extension":"png","size":205674,"mime_type":"image/png","width":1262,"height":1264,"has_preview_image":true},{"id":"iuk4ow81ppgmigzr8ugeahq7tr","user_id":"8fa9tyyk7jymzgbemhuy6ert9w","post_id":"ngkaqozwqtdtxgeykwsc84y11r","create_at":1535459022330,"update_at":1535459022330,"delete_at":0,"name":"Näyttökuva 2018-08-28 kello 15.18.52.png","extension":"png","size":161012,"mime_type":"image/png","width":1248,"height":1110,"has_preview_image":true},{"id":"bi97e1g1zbyh8qt513kss89hqw","user_id":"8fa9tyyk7jymzgbemhuy6ert9w","post_id":"ngkaqozwqtdtxgeykwsc84y11r","create_at":1535459022340,"update_at":1535459022340,"delete_at":0,"name":"Näyttökuva 2018-08-28 kello 15.21.12.png","extension":"png","size":272901,"mime_type":"image/png","width":1256,"height":1256,"has_preview_image":true},{"id":"1ajneqtocpy48cgpf36gux3g4w","user_id":"8fa9tyyk7jymzgbemhuy6ert9w","post_id":"ngkaqozwqtdtxgeykwsc84y11r","create_at":1535459022463,"update_at":1535459022463,"delete_at":0,"name":"Näyttökuva 2018-08-28 kello 15.21.55.png","extension":"png","size":212716,"mime_type":"image/png","width":1228,"height":1256,"has_preview_image":true}]
After this is requested from api, the user interface will crash.
Yep we are using version 5.2, I tried to debug this with chrome developer tools but something weird is happening there. Actually all files which are calling sortFileInfos function do have "locale" which is postid.
from mattermost-redux.
Thanks! Are you using release version of 5.2 (not modified)?
from mattermost-redux.
that part of the ui is default 5.2
from mattermost-redux.
Sorry @zetaab but I really couldn't repro this issue and can't see how to fix this. I guess we'll revisit this case whenever we have reproducible steps.
from mattermost-redux.
@zetaab Can you still reproduce this issue?
from mattermost-redux.
it might be that this was fixed in #685 but I cannot reproduce it anymore because we set now default language for all users.
from mattermost-redux.
Closing this one for now. Please open again @zetaab if you encounter this problem again.
from mattermost-redux.
Related Issues (20)
- type definition of Client4 don't match api definition
- Use official redux-offline. HOT 2
- Update to isomorphic-fetch 3.x to resolve vulnerability in transitive dependency node-fetch HOT 13
- Rudderlabs sets cookie for whole domain HOT 2
- Login does not save token
- groups types
- npm [email protected] is missing built files HOT 5
- Missing release for removing `redux-offline` HOT 4
- Test issue please ignore HOT 12
- Reactions broken on subpath installation of Mattermost HOT 4
- The latest npm (v1.2.0) is not sync with the latest code(now at tag v5.2.0) HOT 1
- CORS issue with Client4, can't get localhost:3000 to communicate with localhost:8065 HOT 1
- uploadFile not working. Content type not set in upload function
- Installing mattermost-redux for a global package fails HOT 2
- How to remove / delete a uploaded file from mattermost-server ? HOT 2
- report redux utils not found error when build Mattermost-webapp HOT 2
- Running React Native app with mattermost-redux fails. HOT 5
- Remove offline features from library HOT 1
- Updated dependency fails RN app HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mattermost-redux.