Comments (13)
Thanks for the report, @sbley! We'll be doing a round of dependency updates later this week, so we can take a look at it then. By the sound of the advisory, it shouldn't affect us since we're not limiting the size of responses here, but it's still good to know about.
from mattermost-redux.
Actually, if you're looking for the mattermost-redux release, I don't know why we didn't have a release cut for it for 5.30 or 5.31. I'll look into why that's not happening. Perhaps there's something being missed in our build process.
from mattermost-redux.
@hmhealey, sounds good. Are you planning to add these updates also to current ESR version 5.25.x?
from mattermost-redux.
No, we're not planning on it.
Looking into it a bit further, while isomorphic-fetch is listed under dependencies, it's actually only used for the unit tests. The web/desktop apps use the native browser and Electron versions of fetch, so they wouldn't be affected anyway. I'll make a note to fix that when we're updating the dependencies.
from mattermost-redux.
Could isomorphic-fetch
be a devDependency, then?
In our project we are constrained to use only ESR versions of Mattermost. On the other hand, we have strict policies to not use any vulnerable dependencies in our code.
from mattermost-redux.
Yeah, it should be under devDependencies. Even though it's under dependencies though, I don't think it's shipped with actual releases since it's only referenced by test code.
from mattermost-redux.
Hi @hmhealey. Have you had a chance to update the dependencies?
If it helps, I could create a pull request that moves isomorphic-fetch
to the devDependencies.
from mattermost-redux.
No sorry, I haven't had a chance to do that yet. We'd definitely welcome a PR to move that though 🙂
from mattermost-redux.
@sbley Thanks again for bringing this up and for the PR. At this point, it'll be included in the 5.31 release of mattermost-redux coming out in January. In the mean time, since you said you're only able to use ESR versions, do you have a fork of this that you can use? Even if we were to get this into an update to the ESR, I'm not actually sure if we cut new versions of mattermost-redux for it because it usually doesn't change in them.
from mattermost-redux.
Hi @hmhealey. We are planning to release (code freeze) end of January, so updating to 5.31 would be an option. Is your release date "in January" pretty reliable or could it also be delayed until February?
from mattermost-redux.
Our releases are consistently in the middle of the month around the 16th. It's sometimes moved by a few days due to weekends, but that's only a few days at most.
from mattermost-redux.
Hi @hmhealey, can we expect a release by the end of the week (Jan 22)?
from mattermost-redux.
The release was cut last week, so it should be available now from https://mattermost.com. It's also our next ESR release since I know you mentioned you could only use ESRs.
from mattermost-redux.
Related Issues (20)
- type definition of Client4 don't match api definition
- Use official redux-offline. HOT 2
- Rudderlabs sets cookie for whole domain HOT 2
- Login does not save token
- groups types
- npm [email protected] is missing built files HOT 5
- Missing release for removing `redux-offline` HOT 4
- Test issue please ignore HOT 12
- Reactions broken on subpath installation of Mattermost HOT 4
- The latest npm (v1.2.0) is not sync with the latest code(now at tag v5.2.0) HOT 1
- When uploading multiple images with same timestamp, the redux fails HOT 9
- CORS issue with Client4, can't get localhost:3000 to communicate with localhost:8065 HOT 1
- uploadFile not working. Content type not set in upload function
- Installing mattermost-redux for a global package fails HOT 2
- How to remove / delete a uploaded file from mattermost-server ? HOT 2
- report redux utils not found error when build Mattermost-webapp HOT 2
- Running React Native app with mattermost-redux fails. HOT 5
- Remove offline features from library HOT 1
- Updated dependency fails RN app HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mattermost-redux.