Comments (5)
@metanerd Should I open a ticket to investigate?
from mattermost-redux.
I suggest switching to a newer release version due to npm tags disallowing publishing a lower release version.
from mattermost-redux.
I suggest switching to a newer release version due to npm tags disallowing publishing a lower release version.
That can't be true. You may not be able to republish a version (I'm not sure) but projects maintain multiple major releases all the time, updating 1.1.0 to 1.1.1 and at the same time having published 2.0.0 and 3.1.0 for example.
You may not think it's worth publishing 5.29.3 to fix the broken 5.29.2 and that's fine, but that npm tags won't allow it is not a good reason.
I personally just reverted to 5.29.1, however having a broken publicly published package seemed worth reporting (and I'd think it was worth fixing, but that's just me).
from mattermost-redux.
Yes, you are absolutely correct in reporting it. Thank you for that! I ran into some issues before with the way we publish the package. I will however look into it again.
I checked the code and the changes from 5.29.1 to 5.29.2 are regarding the migration for the build process, which caused the bug you reported:
https://github.com/mattermost/mattermost-redux/compare/v5.29.1...v5.29.2?expand=1
This means using the 5.29.1 version is perfectly fine.
You are completely correct that the latest version of 5.29 should not be broken and it currently is.
from mattermost-redux.
Thanks @metanerd for your response and letting me know what the cause was, I really appreciate it.
from mattermost-redux.
Related Issues (20)
- type definition of Client4 don't match api definition
- Use official redux-offline. HOT 2
- Update to isomorphic-fetch 3.x to resolve vulnerability in transitive dependency node-fetch HOT 13
- Rudderlabs sets cookie for whole domain HOT 2
- Login does not save token
- groups types
- Missing release for removing `redux-offline` HOT 4
- Test issue please ignore HOT 12
- Reactions broken on subpath installation of Mattermost HOT 4
- The latest npm (v1.2.0) is not sync with the latest code(now at tag v5.2.0) HOT 1
- When uploading multiple images with same timestamp, the redux fails HOT 9
- CORS issue with Client4, can't get localhost:3000 to communicate with localhost:8065 HOT 1
- uploadFile not working. Content type not set in upload function
- Installing mattermost-redux for a global package fails HOT 2
- How to remove / delete a uploaded file from mattermost-server ? HOT 2
- report redux utils not found error when build Mattermost-webapp HOT 2
- Running React Native app with mattermost-redux fails. HOT 5
- Remove offline features from library HOT 1
- Updated dependency fails RN app HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mattermost-redux.