marxjohnson / moodle-block_quickfindlist Goto Github PK

As reported by Alan Woerner

The issue Alan describes occurs as the has_capability call in get_content uses the system context, not the current instance context. This is partly due to laziness, but also partly down to security as the block potentially searches all users in the system. Extra permissions checking may need to be implemented to ensure that a user only sees results for users that they are allowed to know about.

From http://tracker.moodle.org/browse/CONTRIB-2759

This block along with the quick find block are really useful to our users.
Upon discussion with a colleague I thought I would float a couple of things that we think would make the blocks even better:
...
2) When returning results to include a small thumbnail of the user next to their name

I'm not a php coder so am not sure how feasible or practical these enhancements would be to implement.

Strict Standards: Creating default object from empty value in /home/garderief/public_html/blocks/quickfindlist/block_quickfindlist.php on line 201

I think it'd be better to redirect them to the site-wide profile (rather than course profile). Thoughts?

Hi,

sorry for double-posting, but I don't know if you are subscribed to Moodle Tracker.

Please have a look at http://tracker.moodle.org/browse/CONTRIB-3566

Thanks in advance
Alex

We put the students idnumber on the mdl_user idnumber field and it's useful to be able to search for students by this number.

below is a patch that enables this - it includes knocking out accounts from search with a lastname of 'Guardian' as we use this to create guardian access accounts for our students

git://gist.github.com/3175344.git

Hi,
Could you please add support for Moodle 4?
Even if the current version of the plugin would work on Moodle 4, an official support would be great.

Thanks even for considering it :-)

could you develop the block for moodle ver 3.2

Getting a lot of these errors in my error log. A quick replacement of pix_url with image_url on line 126 of block_quickfindlist.php fixed it.

On Line 126 of block_quickfindlist.php change pix_url to image_url

On line 37 of quickfind.php, change:

$context = get_context_instance(CONTEXT_COURSE, $courseid);
to
$context = context_course::instance($courseid);

This fixes some MySQL-specific and erroneous quoting, so it now runs on other RDMS systems such as Microsoft SQL Server. More specifically:

Bound parameters are not quoted, as the binding handles that (uses ?, not "?").

String literals use single quotes, double quotes are for identifiers (MySQL accepts backticks for identifiers):
http://www.savage.net.au/SQL/sql-2003-2.bnf.html#character%20string%20literal

Use Moodle's $DB->sql_concat rather than MySQL-specific CONCAT()

sensei-hacker@e708c80

Hi,

sorry for double-posting, but I don't know if you are subscribed to Moodle Tracker.

Please have a look at http://tracker.moodle.org/browse/CONTRIB-3568

Thanks in advance
Alex

It does not recognize some accented characters from my language (those are correct UTF-8 characters, and there is no such problem on database), for instance š ř č (see example). On the other hand, it correctly "parses" vowels like á ö ... as a, o (I am on Moodle 2.6.7, if it helps)

master (Moodle 2.6DEV) throws this warning:

get_context_instance() is deprecated, please use context_xxxx::instance() instead.

In deprecatedlib.php, I see get_context_instance has been deprecated since 2.2.

On line #97 of blocks/quickfindlist/block_quickfindlist.php, change:

$context_system = get_context_instance(CONTEXT_SYSTEM);

to:

$context_system = context_system::instance();

Hi,

sorry for double-posting, but I don't know if you are subscribed to Moodle Tracker.

Please have a look at http://tracker.moodle.org/browse/CONTRIB-3569

Thanks in advance
Alex