Coder Social home page Coder Social logo

Comments (5)

marxjohnson avatar marxjohnson commented on June 26, 2024

So this is a case where you've not configured a role or a custom URL, and you're using the block from inside a course, it will still return users who aren't enrolled on that course?

I'd be a bit concerned that having different behaviour for different users might be a cause for confusion. It's probably not obvious why clicking on one user would keep you in the course context while another would take you to the system context. I'd say either everyone's links should go to the site-wide profile by default, or it shouldn't return users from outside the course when you're using the block within a course.

from moodle-block_quickfindlist.

davidpesce avatar davidpesce commented on June 26, 2024

My thought was that everyone would get redirected to the site-wide profile. Would there be a reason not to?

from moodle-block_quickfindlist.

davidpesce avatar davidpesce commented on June 26, 2024

Where is the config->url set? There aren't config settings for the block (that I'm seeing)...

if (empty($this->config->url)) {
$url = new moodle_url('/user/view.php', array('course' => $COURSE->id));
} else {
$url = new moodle_url($this->config->url);
}

from moodle-block_quickfindlist.

davidpesce avatar davidpesce commented on June 26, 2024

Now there's an interesting thought. What if we made this an admin setting?

from moodle-block_quickfindlist.

marxjohnson avatar marxjohnson commented on June 26, 2024

Where is the config->url set? There aren't config settings for the block (that I'm seeing)...

It should be a per-instance config setting, on the same form that controls where the block appears etc.

from moodle-block_quickfindlist.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.