martinsson / bugszero-kata Goto Github PK

The title is kind of self-explanatory 😃

The CSharp code base is a copy from https://github.com/evilz/kata

The test script is changed to not contain illegal input, however the
test reference file is not changed. So once you get the test running it
will fail. You'll have to just validate the new result as the reference
result. I don't have an environment to do it.

Right now it's easy to launch the tests from phpstorm, but it's a bit tricky to launch them from the commandline. It'd be nice to have some documentation on launching the tests using a commandline

As mentionned in instructions-intermediate.md, there is some bugs/problems with the code :

• A player that get's into prison always stays there
• bug with the money attribution, coins are added to the wrong player
• typo (corrent instead of correct)

Fixing theses will break the test, so it could be good to have a file with the correct output so we can switch on it when they are fixed

In the spirit of the advanced instructions, I'll describe an issue in the current form of the README.md.

1. Weakness: Text does not have an inclusive language. Specifically in the subsentence ...it is likely that a developer would create a bug if he extended the code.
2. What is the potential bug: Using "male-centric" wording supports the stereotype of developers being male. Yet developers come in all shapes and forms, including genders. The text is not about a particular example person, it is meaning "any" person.
3. Proposed alternatives: Here it can become tricky, yet the English language gives us options. Suggestions:

• ...it is likely that developers would create a bug if they extended the code. -- developers in complete plural.
• ...it is likely that a developer would create a bug if they extended the code. -- Usage of singular they, which is getting more common and may also be rejected by some.
• ...it is likely that a developer would create a bug by extending the code. -- completely avoiding it.

How do you see it?