markreeder / turntable.fm-extensions Goto Github PK

So allow me to select both "'80s" and "alternative" and it'll show only alternative songs from the '80s. Or with a different toggle thrown, allow it to show both alternative songs and '80s songs.

Love the extension though.

There's not really a need to display the information twice.

Add a color chart of the CSS classes for recentlyPlayed, etc.
Maybe in extension settings?

Example of broken JSON:
https://gist.github.com/7ca788199b16ae3b5f75

File id:
4e1d149399968e6fc90026f9

Occasional error: when a song changes and a notification pops up, it displays the correct song, but it says it is being spun by the previous DJ that played. The song change and DJ change might happen at different times, so look into if the event is firing before the DJ change happens.

Possible fixes:

• use a different event listener that will be updated by the time the current DJ is updated.
• introduce a <1s 'fudge factor' delay to make sure the current DJ has been updated.

Chrome 12.0.742.122
TTFM Extended 0.5.0.4_0 (installed yesterday)

After installing the extension, restarting my browser (just to be sure), setting up the bookmarklet:

and clicking on the bookmarklet, I get the gear. However, after clicking the gear, the JS console in Chrome shows me:

Uncaught TypeError: Cannot read property 'upvoters' of undefined [turntable.fm.extend.js:142]

and, of course, nothing actually happens.

The event that gets hooked into for triggering song change events fires before the song starts playing and sometimes the auto awesome doesn't work as a result.

Proposed fix: Re-work the way that auto-awesome works by adding a countdown to awesome over the awesome button. This should be a cancelable event if you decide that you don't actually want to awesome a track.

anonymous
Hey Mark, I'm in the same boat as James. Any advice would be much appreciated! Also..great idea!!

James
Great idea Mark, but I'm having a problem getting it to work. Initial install asked me to autenticate with my Last.FM account, which I did but scrobbling was not working. I followed your instructions below to delete the session token, but it did not ask me to re-authenticate and no new token has been created. Any ideas?

Alert needs to be removed.

Currently, tags will not be updated at another computer. Not sure if this is something that can be tied into an account, or handle it where it spits out code for you that you can email yourself then paste it into an input at home and it updates all your tags for your music.

Or even make it part of your gmail account? (not sure if that is doable)

Getting a notification for every chat is too much so I turn them off. But if someone is trying to talk to me I'd like to be able to respond without having to read through the entire chat window looking for my name.

When I first load the page in a room, the plugin works as expected. However after a little use, the tag links somehow become offset in my queue so that when I click a tag icon on a song, it brings up the tags dialog for the next song in the queue instead of the one I clicked on. I am able to open the tags for the song at the top of the list (or the one that's playing) by clicking the tag icon for the last song in the queue, so it does roll over. The black tag icons that indicate which songs have been tagged are also offset by one.

Everything else works great. Clicking tags in the tag list bring up the correct songs for the tag.

Idle time stays the same for every DJ and it is not showing the true idle time.

I think it'd be nice if you could click on a desktop notification from chrome and have it focus the browser on the tab running tt.fm.

Is this feature supposed to work in 0.6.0.1? The behavior I see is that I click "get tags from last.fm" and the text changes to "Loading tags from last.fm, please be patient..." But no matter how patient I am, nothing else ever happens.

There are no errors on the JavaScript console. I know nothing about JavaScript, but stumbling around in the debugger it appears that turntable.fm.extend.js dispatches a "tt-ext-get-song-tags" event to contentscript.js, but there is no corresponding handler in that script? I apologize if that's useless or just plain wrong; it was the best I could come up with!

Thanks again and please let me know if there is anything else I can do to help.

Scrobbles should adhere to the 50% / 4min rules for actual scrobbles and send the Now Playing information at the start of a new track: http://www.last.fm/api/submissions#np

Also, if a track is "Lame"'d, it should be excluded from scrobbling.

hey Mark!

Should be an option to see all tracks, tagged or not.

Noticed 3 script errors today in the console when I noticed that Desktop notifications were not showing up. I went to the settings dropdown to check out the extension settings but clicking it does nothing. Here is the error I'm getting:

XMLHttpRequest cannot load chrome-extension://mnciafhfaahhafklckmcabbncbgcjpeg/css/turntable.fm.extend.css?v=0.6_1316711071445?null. Origin http://turntable.fm is not allowed by Access-Control-Allow-Origin.
default.js:20

Uncaught Error: NETWORK_ERR: XMLHttpRequest Exception 101
chrome-extension://mnciafhfaahhafklckmcabbncbgcjpeg/js/turntable.fm.extend.js?v=0.6_1316711071441:1694

Exception during attachListeners TypeError: Cannot read property 'fileId' of undefined
at HTMLDivElement. (chrome-extension://mnciafhfaahhafklckmcabbncbgcjpeg/js/turntable.fm.extend.js?v=0.6_1316711071441:481:44)
at Function.each (http://code.jquery.com/jquery-1.6.1.min.js:16:12192)
at [object Object].each (http://code.jquery.com/jquery-1.6.1.min.js:16:8877)
at Object.updateQueueTagIcons (chrome-extension://mnciafhfaahhafklckmcabbncbgcjpeg/js/turntable.fm.extend.js?v=0.6_1316711071441:480:35)
at chrome-extension://mnciafhfaahhafklckmcabbncbgcjpeg/js/turntable.fm.extend.js?v=0.6_1316711071441:1212:10
at chrome-extension://mnciafhfaahhafklckmcabbncbgcjpeg/js/turntable.fm.extend.js?v=0.6_1316711071441:1251:5
at chrome-extension://mnciafhfaahhafklckmcabbncbgcjpeg/js/turntable.fm.extend.js?v=0.6_1316711071441:1083:4
at chrome-extension://mnciafhfaahhafklckmcabbncbgcjpeg/js/turntable.fm.extend.js?v=0.6_1316711071441:1693:3
at Object. (chrome-extension://mnciafhfaahhafklckmcabbncbgcjpeg/js/turntable.fm.extend.js?v=0.6_1316711071441:1696:49)
at Object.resolveWith (http://code.jquery.com/jquery-1.6.1.min.js:16:15102)

Great extension. I dig the tag functionality compared to the playlist functionality provided by another extension, but it would be awesome if there was support for syncing to Dropbox so your tags would work across multiple computers.

Some folks have complained that the tag functionality slows down the extension. In the long term we should optimize it, but in the short term we should make it configurable in "Extension Settings" - it can default to on though.

When you are in turntable.fm room, trying to fast-finger-click onto stage, this plug will cause everything on the page to lock up. I've tried disabling all my other chrome plug-ins, and was able to narrow it down to this one causing the issue. I've mostly noticed this issue ever since the 0.6.3.4 release.

I am using a WIndows XP laptop running Chrome. It is not set to delete cookies after logging off.

My Turntable FM mp3 tags are lost after each time I log onto Turntable FM. I can't find any information about this problem
and it seems to affect none of my friends.

I was able to get the integration working following the java console fix, but that's about all it did. I'm able to view members of a room, and the links within that window work fine. However, I don't get any news of track changes, I can't see what the status of track votes are, nothing. In the console window, this was all pretty bunched up and, admittedly, I am not savvy in code at all, so I don't really have any clue what I'm looking at:

Failed to load resource
Unsafe JavaScript attempt to access frame with URL http://static.ak.facebook.com/connect/canvas_proxy.php?version=3#method=setSize&params=%7B%22width%22%3A760%2C%22height%22%3A730%2C%22frame%22%3A%22iframe_canvas%22%7D from frame with URL http://turntable.fm/lobby. Domains, protocols and ports must match.
3Unsafe JavaScript attempt to access frame with URL https://www.facebook.com/extern/login_status.php?api_key=127146244018710&app_id=127146244018710&channel_url=https%3A%2F%2Fs-static.ak.fbcdn.net%2Fconnect%2Fxd_proxy.php%3Fversion%3D3%23cb%3Df27710c6f4%26origin%3Dhttp%253A%252F%252Fturntable.fm%252Ff2245d6fd%26relation%3Dparent.parent%26transport%3Dpostmessage&display=hidden&extern=2&locale=en_US&next=https%3A%2F%2Fs-static.ak.fbcdn.net%2Fconnect%2Fxd_proxy.php%3Fversion%3D3%23cb%3Df394441608%26origin%3Dhttp%253A%252F%252Fturntable.fm%252Ff2245d6fd%26relation%3Dparent%26transport%3Dpostmessage%26frame%3Df2587e7dc8%26result%3D%2522xxRESULTTOKENxx%2522&no_session=https%3A%2F%2Fs-static.ak.fbcdn.net%2Fconnect%2Fxd_proxy.php%3Fversion%3D3%23cb%3Df140308754%26origin%3Dhttp%253A%252F%252Fturntable.fm%252Ff2245d6fd%26relation%3Dparent%26transport%3Dpostmessage%26frame%3Df2587e7dc8&no_user=https%3A%2F%2Fs-static.ak.fbcdn.net%2Fconnect%2Fxd_proxy.php%3Fversion%3D3%23cb%3Df3a66c44a8%26origin%3Dhttp%253A%252F%252Fturntable.fm%252Ff2245d6fd%26relation%3Dparent%26transport%3Dpostmessage%26frame%3Df2587e7dc8&ok_session=https%3A%2F%2Fs-static.ak.fbcdn.net%2Fconnect%2Fxd_proxy.php%3Fversion%3D3%23cb%3Dfb6e8c164%26origin%3Dhttp%253A%252F%252Fturntable.fm%252Ff2245d6fd%26relation%3Dparent%26transport%3Dpostmessage%26frame%3Df2587e7dc8&sdk=joey&session_origin=1&session_version=3 from frame with URL http://turntable.fm/lobby. Domains, protocols and ports must match.

Some, myself included, have had problems with the latest version of the extension and Chrome v12.0.742.112. My JSConsole shows two errors:

turntable.fm.extend.js:906 SyntaxError: Unexpected token ILLEGAL
turntable.fm.extend.js:910 undefined is not a function

Wondering if these errors explain the problems between these versions of Chrome and the extension.

Is it possible? Users of our room are up in arms at its intrusiveness and lack of theme. Plus, the auto-tags are all wrong and songkick pulls up slightly wrong bands instead of the band playing.

When visiting the https version of turntable, the extension doesn't work.

My Last.fm suggestions seem to load for the first song that I hear in a room, then never refresh. The "Suggestions" link stays at the top of the queue, and clicking the link opens the suggestions list, but the songs in that list never change.

v0.5.0.2 on Chrome for Mac 14.0.814.0 dev

Please let me know if you have any ideas or need additional details. Thanks!

Since the red line is just the first song not of the active tag, moving it could end up not doing what you expect.

The red line could be engineered out by automatically moving the first item from the active tag to the top when you're on deck and you're up next.

Chrome: 12.0.742.112
Turntable: 0.3.5
Mac OS: 10.6.8

In the Chrome Javascript console:

Running First Migration turntable.fm.extend.js:37
performMigrations: enabling scrobbling turntable.fm.extend.js:44
SyntaxError: Unexpected token ILLEGAL turntable.fm.extend.js:906
undefined is not a function turntable.fm.extend.js:910

I used to have the extension working before the update. I tried reinstalling the extension, restarting chrome, deleting extension cache.

Opening an issue to start a discussion - I'm split on this and would like others' opinions...

From the last.fm docs:
"This [scrobble] data is used to show a user's listening history and generate personalised charts and recommendations (and more)."

My own opinion:
In most scrobble apps, the user is in control of the music. It is this system that allows last.fm to generate its personalized charts. TTFM is more of a "radio" station, so it isn't quite right to scrobble every song that isn't lamed. A major use case for using TTFM is putting it on in the background (that's why the song change notifications are so awesome). That means that you're not always going to be around to "Lame" a track to ensure that it doesn't get scrobbled. This means that plenty of music will get added to the user's last.fm profile by mistake. The "now playing" is already being used to track each song that is played - and this makes perfect sense.

I am thinking that we should only scrobble when a user votes "awesome" on a track. That way the integrity of their last.fm profile is maintained...

What do others think?

I find weird that sometimes the "Suggestions" link disappear or it is just disabled.
I can't tell if it's working or not.

I'd love a link to the artist page on last.fm even if no results. Maybe the link uses a different color.

Maybe some last.fm icon too?
I love those integration icons! share the love. <3

the body of the new lobby loads, but the friend icons never load and scrollbar never loads. eventually get the "kill page" popup.

It'd be cool if we created a notification when a song was about to end. I'm going to get started on this and will keep you guys updated

Now that facebook links were removed can we use that space to restore the vote log?

TFMEX.roomInfo.users[TFMEX.roomInfo.moderatorId]

Great extension!!

I've been looking for a solution to be able to vote without having to switch back to the browser, find the ttfm tab and then vote. It would be great if your song notification popup also included thumbs up/thumbs down buttons to vote from there.

I found a new extension today, Turntable Plus (http://sosimpull.com/), that has this feature and it looks to use the same notification engine as yours. It's rather ugly though and I'd rather just use your extension exclusively! That shows that it's possible though.

Being able to adjust the notification display time would be very helpful to go along with the voting buttons as well.

Thanks and keep up the great work!

don't know what the problem with this is, but all of a sudden chrome wouldn't let me log in to turntable whenever i chose to use the facebook login button because the facebook button wasn't clickable anymore.
i'm using windows 7, btw. if that means anything.

here's what it looks like: http://i.imgur.com/AxLwh.jpg

can someone please help me out with this?

by the way, turntable does let me log in with facebook on mozilla, but just not chrome.

I tried to disable the Song Messages notification and it stopped working for everything else.
even if I turn that on again, no more notifications.

Thanks

Link format: http://www.facebook.com/profile.php?id=

Given TTfm's occasional bugginess, I had always assumed this was their fault, but it appears to be the Turntable.fm Extended extension that's slowing down the interface.

I have 780 items in my queue. When I enable the Turntable.fm Extended extension, the head-bobbing animations become severely choppy and clicking repeatedly in any area of the interface causes all the animations to seize up for up to several seconds.

This occurs in all of the latest stable, beta, and dev Chrome builds, and I have reproduced it in the latest versions of Mac OS X, Ubuntu, and Windows 7. Doesn't seem to make a difference which features of the extension I have enabled or disabled, as long as the extension itself is turned on. Disabling all other extensions does not help, and there are no errors present in the Javascript console.

When I signed in with a dummy account with no queue and the extension enabled, these issues did not present.

If there's any further info I can provide, I'd be happy to; I just don't know much of anything about how Chrome extensions work or what info might be valuable. Is there anything I might try to enhance performance aside from paring down my queue? Or is this something inherent in how the extension needs to be to work with the TT interface?

Thanks!

http://code.google.com/chrome/extensions/notifications.html

"permissions": [
"notifications"
],

When I click on a tag it brings up the menu for the song below it in the list.

OS: Mac OSX
Browser: Chrome

It'd be nice to have a manageable DJ queue. Perhaps Drag names from the chat window to the window for the Queue with a delete button when someone in the queue gets up on deck.

Edit: Just to clarify - A queue to manage DJs that are waiting for a turn to get on the deck to play songs is what I'm referring to. =)

To recreate:

Load TTFM room
Wait for suggestions link to appear
Click random room
Wait for suggestions link to re-apppear
Check suggestions to see if they make sense

Rinse and repeat.

My queue is getting too big and now it took some extra time to load because of the tag icon inserts!

Thanks