Coder Social home page Coder Social logo

Comments (8)

gilbarbara avatar gilbarbara commented on July 26, 2024

hey Mark!
Actually the notifications duplicate when you change rooms too. maybe reset notificationQueue when changing rooms?

from turntable.fm-extensions.

MarkReeder avatar MarkReeder commented on July 26, 2024

I'll look into that tonight, should be fairly straightforward.

from turntable.fm-extensions.

MarkReeder avatar MarkReeder commented on July 26, 2024

Fixed now, let me know if you run into any more issues.

from turntable.fm-extensions.

gilbarbara avatar gilbarbara commented on July 26, 2024

Hey Mark!
Still getting multiple copies of notifications when changing rooms. The second room I get two, third room I get three and so on. Maybe multiple copies of event listeners?

from turntable.fm-extensions.

MarkReeder avatar MarkReeder commented on July 26, 2024

Saw that- seems like the code I had didn't fully resolve the issue. I have a crude fix currently checked in that reloads the page automatically when you visit a new room, but I'm not thrilled with that solution. I'll try to get a more robust fix up tonight.

from turntable.fm-extensions.

MarkReeder avatar MarkReeder commented on July 26, 2024

Should be fixed for real this time. Preferences should also stick between sessions and display properly.

from turntable.fm-extensions.

gilbarbara avatar gilbarbara commented on July 26, 2024

sweet! working good!

Hey, are you interested in a css rework of the prefs? I could do it.
You definitely need to add references to matchesRecentlyPlayedExactly, matchesRecentlyPlayedArtist, etc.

[s]

from turntable.fm-extensions.

MarkReeder avatar MarkReeder commented on July 26, 2024

Yeah, I've got some things I've been meaning to do with the styling of the prefs stuff, but have been busy with fixing compatibility issues and bugs recently. If you'd like to have a shot at it, go for it.

Definitely agree on the queue highlighting stuff...

from turntable.fm-extensions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.