Comments (8)
hey Mark!
Actually the notifications duplicate when you change rooms too. maybe reset notificationQueue when changing rooms?
from turntable.fm-extensions.
I'll look into that tonight, should be fairly straightforward.
from turntable.fm-extensions.
Fixed now, let me know if you run into any more issues.
from turntable.fm-extensions.
Hey Mark!
Still getting multiple copies of notifications when changing rooms. The second room I get two, third room I get three and so on. Maybe multiple copies of event listeners?
from turntable.fm-extensions.
Saw that- seems like the code I had didn't fully resolve the issue. I have a crude fix currently checked in that reloads the page automatically when you visit a new room, but I'm not thrilled with that solution. I'll try to get a more robust fix up tonight.
from turntable.fm-extensions.
Should be fixed for real this time. Preferences should also stick between sessions and display properly.
from turntable.fm-extensions.
sweet! working good!
Hey, are you interested in a css rework of the prefs? I could do it.
You definitely need to add references to matchesRecentlyPlayedExactly, matchesRecentlyPlayedArtist, etc.
[s]
from turntable.fm-extensions.
Yeah, I've got some things I've been meaning to do with the styling of the prefs stuff, but have been busy with fixing compatibility issues and bugs recently. If you'd like to have a shot at it, go for it.
Definitely agree on the queue highlighting stuff...
from turntable.fm-extensions.
Related Issues (20)
- tags are lost after every new session!?! HOT 3
- disable songkick integration? HOT 3
- "ON TOUR" banner survives settings check-off HOT 3
- Change the backgroung color for Concert Notifications
- Change the backgroung color for Concert Notifications
- Can we find a way not to have to type the tags? HOT 1
- Tag icon covers X, can't remove songs from queue HOT 3
- notifications HOT 1
- still having issues with the notifications HOT 1
- 'Untagged' tag HOT 2
- Last.fm Scrobble feature doesn't stay checked HOT 14
- Song Count Incorrect. HOT 1
- Some tags show more songs than show up when selected HOT 1
- Feature: Docked Room User List
- Lost all tags -- where are they stored?
- My Tags will no longer open! HOT 1
- Removing tag category from master list HOT 1
- Unable to Add Song Tags: Web Page Reloads HOT 2
- Links to chrome extension in README 404
- Feature: auto-like songs
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from turntable.fm-extensions.