Comments (1)
I tried taking an initial stab at it by reworking the PdsEnvVarRow to be more generic PdsKeyValRow and reusing it for labels, but i think a view has to be unique to each widget, otherwise the values end up in both children that match this class.
Is creating a separate view and model for labels the way to go or is there something that would allow for a more generic view like PdsKeyValRow to be reused for both labels and environment variables?
Yeah, I think it's for both PdsEnvVarRow
(view) and EnvVar
(model) ok to be used in a more generalized way for this purpose.
So, renaming them, like you did, to PdsKeyValRow
and to KeyVal
(model) is all what needs to be done, AFAICS. You also need to rename the ui file data/resources/ui/env-var/row.ui
and update data/resources/resources.gresource.xml
.
The renaming part in the container creation page would be quite straightforward because you've already done the same thing in #329
If we want to use other strings than "Key" and "Value" (screenshot) for the container labels, we could also define these two strings as glib properties in the PdsKeyValRow
to make them customizable.
from pods.
Related Issues (20)
- arabic translation HOT 2
- Panic while selecting trying to download new images HOT 7
- Fails to start - bwrap: Can't create file at /run/systemd/journal/socket: No such device or address HOT 3
- Add ukrainian language to weblate HOT 2
- podman API library HOT 2
- Removes images in use by a container without warning HOT 1
- add support for docker compose files via podman-compose
- Flathub Beta submission HOT 7
- image download indicator on header bar HOT 1
- refreshing images and containers HOT 5
- Translations: Add context to Podman Pods
- No permission to start Turkish translation HOT 1
- No way to define command arguments when creating a container
- Restyle container rename dialog
- the return to main page button is confusing
- Is it possible to rebuild it for Windows HOT 3
- add ability to create containers as root HOT 5
- Mention somewhere how to activate podman socket HOT 2
- Relatively long time needed to load (images and contaiers) on startup HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pods.