Coder Social home page Coder Social logo

podman API library about pods HOT 2 CLOSED

marhkb avatar marhkb commented on June 10, 2024
podman API library

from pods.

Comments (2)

marhkb avatar marhkb commented on June 10, 2024

Many thanks for this tip. Nevertheless, I decide against this approach for the following reasons.

  1. the generated code still needs to be adapted to be compiled (replacing crate::model::Array with serde_json::Value::Array)
  2. it is very cumbersome to use the API because no builders are provided (long method signatures)
  3. it seems that system_events_libpod, container_logs_libpod and containers_stats_all_libpod do not return streams. This breaks the basic functionality of the application.
  4. I think it's too much effort to change the library while we don't know yet what other cans of worms we might open in this process.

In contrast, podman-api-rs is a very convenient crate and I think it would be much less effort to fix the problems there that we have experienced.
I will leave this issue open as I still think the point you raise is valid. So I am willing to change my mind if someone wants to do the hard research to find out if the generated code is better.

from pods.

marhkb avatar marhkb commented on June 10, 2024

Closing this. The cooperation with upstream is very good, and it seems all issues are resolved. Also, at this point, Pods is too tightly coupled with podman-api-rs. The effort of changing the backend would be very high. Future Issues should be addressed upstream directly.

from pods.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.