lxqt / lxqt-admin

LXQt system administration tool

LXQt

LXQt is the next generation of LXDE, the Lightweight Desktop Environment. It is the product of the merge between Razor-qt and LXDE-Qt.

About this repository

This is a superproject which contains all LXQt components. After checking out this repo please do the following to initialize git submodules.

git submodule init
git submodule update --remote --rebase

Note: We require git >= 1.8.5

Contributing

If you are interested in helping or joining LXQt, please take a look at our CONTRIBUTING document

Translation

Translations can be done in LXQt-Weblate.

---

lxqt-admin's Issues

Can't build on Arch Linux

Whenever I try to build it using cmake ../ from the build directory, and then make, it errors out with lxqt-admin-time/main.cpp:28:28: fatal error: LXQt/Application: No such file or directory

Not sure how to resolve, but I will study the code a bit. Please let me know if you have a better solution.

Not released yet

subj

Localization problems

lxqt-admin/lxqt-admin-time/timezone.ui

Line 26 in a723516

<string>TextLabel</string>

What does this label stand for? I cannot understand it

Add translation promo

lxqt-admin-time doesn't work on non-systemd GNU/Linux systems

Please provide a build-time option to use a generic backend.

It's most likely will be ok to use the same as for freebsd.

1569299c4020f9b96a5850ef26fe9fb4544071dd breaks date/time admin on FreeBSD

I submitted a patch to allow date and time administration to work on Linux systems that do not have systemd. The patch was applied in commit 1569299. Jesper Schmitz Mouridsen has reported that date/time administration no longer works on FreeBSD. Looking again at my patch I see that the problem is caused by my patch. Please see the discussion at #136.

Expected Behavior

Time and date administration should function correctly on FreeBSD.

Current Behavior

Jesper's report doesn't describe the problem on FreeBSD in detail, just saying , effectively, that date and time administration is broken.

Possible Solution

My patch set a new build flag (NO_SYSTEMD) on systems that do not have systemd installed. Since FreeBSD does not include systemd, the flag was set resulting in the wrong code being compiled in lxqt-admin-time/datetime.cpp. My proposed fix is to amend lxqt-admin-time/CMakeLists.txt so that the logic that sets the flag is not executed on FreeBSD systems. I have a patch that does that , which Jesper has reported restores date and time administration on FreeBSD. I have applied the patch to lxqt-admin-1.0.0 and confirmed that date and time administration still works properly on my systemd-less Linux system (which is based on Linux from Scratch). The patch is as follows:

-- lxqt-admin-1.0.0/lxqt-admin-time/CMakeLists.txt.orig 2021-11-10 19:58:57.988708301 +0000
+++ lxqt-admin-1.0.0/lxqt-admin-time/CMakeLists.txt 2021-11-10 20:01:43.784715265 +0000
@@ -59,11 +59,13 @@ lxqt_translate_desktop(DESKTOP_FILES
lxqt_app_translation_loader(lxqt-admin-time_QM_LOADER ${PROJECT_NAME})
#************************************************

+if(${CMAKE_SYSTEM_NAME} MATCHES "Linux")
find_package(PkgConfig QUIET)
pkg_check_modules(LIBSYSTEMD QUIET libsystemd)
if(NOT LIBSYSTEMD_FOUND)
add_definitions(-DNO_SYSTEMD)
endif()
+endif()

add_executable(lxqt-admin-time
${lxqt-admin-time_SRCS}

Steps to Reproduce (for bugs)

1. On a FreeBSD system with lxqt-admin built at or after commit 1569299, select Preferences->LXQt Settings->Date and Time from the LXQt menu.
2. Try to amend the date or time.

Context

My patch has affected me by now being able to use lxqt-admin administer date and time on my systemd-less Linux system. The patch has, however, prevented users on FreeBSD from administering date and time with lxqt-admin.

System Information

It seems obvious that Jesper uses a FreeBSD system, but I do not have the details.

• Distribution & Version:
• Kernel:
• Qt Version:
• liblxqt Version:
• lxqt-build-tools Version:
• Package version:

Logic error in add user dialog

Expected Behavior

Cancelling authorization cancels add user process

Current Behavior

It shows "insert password" after "cancel" in auth dialog

Possible Solution

Steps to Reproduce (for bugs)

1. Open "add user" dialog
2. add an user, auth window is shown
3. hit "cancel"
4. error is displayed and the "insert password" for the user you didn't add is shown

Context

Testing PR #288

System Information

• Distribution & Version: all

Avoid defaulting to /bin/sh when adding a new user

When no selection under "avanced" is made the default shell for new users will be /bin/sh as it's always on top of the list and the selection is empty.
This can be annoying in the new user sessions, as most people are used to see the bash prompt in terminal windows.

Possible Solution

Make sure that if no selection is made shell defaults to /bin/bash if available.

Context

lxqt/lxqt#2163

System Information

• Distribution & Version: all

Issues when canceling a password entry to pkexec

Steps to reproduce:

1. Perform any action which requires pkexec action (e.g add a user)
2. Cancel on password prompt

Actual results:

1. An error message
2. The dialog with settings disappears
3. (In case of adding a new user) A password prompt for the new user is showed.

Expected results:

• Quite the opposite of actual results.

FTBFS introduced in lxqt-admin/pull/134

/pull/134 ui: small tweaks

In file included from /home/agaida/work/code/pkg-main/lxqt-admin/snapshot/lxqt-admin-user/mainwindow.h:25,
                 from /home/agaida/work/code/pkg-main/lxqt-admin/snapshot/lxqt-admin-user/main.cpp:31:
/home/agaida/work/code/pkg-main/lxqt-admin/snapshot/obj-x86_64-linux-gnu/lxqt-admin-user/ui_mainwindow.h: In member function ‘void Ui_MainWindow::retranslateUi(QMainWindow*)’:
/home/agaida/work/code/pkg-main/lxqt-admin/snapshot/obj-x86_64-linux-gnu/lxqt-admin-user/ui_mainwindow.h:172:21: error: ‘class QMainWindow’ has no member named ‘setUserGroupSettingsWindow’
         MainWindow->setUserGroupSettingsWindow(QApplication::translate("MainWindow", "User and Group Settings", nullptr));
                     ^~~~~~~~~~~~~~~~~~~~~~~~~~
make[3]: *** [lxqt-admin-user/CMakeFiles/lxqt-admin-user.dir/build.make:203: lxqt-admin-user/CMakeFiles/lxqt-admin-user.dir/main.cpp.o] Error 1

lxqt-admin: desktop-entry-contains-unknown-key

usr/share/applications/lxqt-admin-time.desktop:19 Comment [cs]
usr/share/applications/lxqt-admin-user.desktop:17 Name [cs]

lxqt-admin-time doesn't list UTC

Expected Behavior

Must list UTC under timezones

Current Behavior

UTC is absent

Possible Solution

I'm assuming the program is essentially parsing /usr/share/zoneinfo/ in some way, in which case UTC has to be listed unless it was hidden on purpose. If so, please bring it back.

Steps to Reproduce (for bugs)

1. Boot Arch
2. Login to lxqt session
3. open lxqt time
4. view the listed timezones

Context

I often change timezones (because I travel). I've been using timedatectl for this before I discovered that lxqt-admin-time has an option for that (PAM support included for auth). However I can't find UTC in the list.

System Information

• Distribution & Version: Arch Linux
• Kernel: 5.14.11
• Qt Version: 5.15.2
• liblxqt Version: 0.17
• lxqt-build-tools Version: -
• Package version: 0.17