luxoftsdl / sdl_core_winport Goto Github PK

We should switch to the llvm 3.6
This version should be verified
Reformat all sources once more with this version of the clang-format

In the sources logging is present. But it doesn't appear in the log file.

• Refactoring of CMakeFiles for all components
• Refactoring Find modules for all 3rd party

Example:
D:\sdl_core_winport\build\sdl_win_x64\src\appMain\storage/235618/icon.png

TimeTester functionality could be enabled by build option in CMakeLists.txt

Return just int32_t instead of bool result + out param. E.g. on windows platform the result is int. This allows to return -1 as error flag. The original problem was that send on posix returns ssize_t.
On my opinion int32_t is more that enough to store the bytes sent. typical tcp frame buffer is 4096 bytes. Input and output queues also have sizes which fits into the int. If we will try more than available free space in the buffer we would get ewouldblock error.

Change in the interface will make the usage much more clear.

Here is one warning sample:

[ 95%] Building CXX object src/components/policy/src/policy/CMakeFiles/Policy.dir/Policy_automoc.cpp.obj
Policy_automoc.cpp
C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\INCLUDE\xmemory(196) : warning C4503: 'std::_Tree_val<_Traits>::_Myval' : decorated name length exceeded, name was truncated
        with
        [
            _Traits=std::_Tmap_traits<std::string,policy::CacheManager::AppCalculatedPermissions,std::less<policy::HMILevel>,std::allocator<std::pair<const std::string,policy::CacheManager::AppCalculatedPermissions>>,false>
        ]

Here is related help from MS: https://msdn.microsoft.com/en-us/library/074af4b6.aspx

SQLPTRepresentation::GatherFunctionalGroupings doesn't fill the rpcs field correctly. Do the permissions are empty.

It seems to be redundant to use apt-get on Windows platform and so on.

QT_PORT build works fine

• Disable only windows specific warnings in winhdr.h file
• Increase warnings level to /W3

This should also be reproducible in Qt version. At least I've faced with issue in my refactored Qt branch.

I've retested this on current develop (win native) and can reproduce the issue.
Steps. Connect SPT. Open full mode. And leave it. After some time there will be "Connection was lost" notification on the HMI side. But SPT will still be in connected mode.
If I didn't do any actions on the SPT side, then there will be quite fast disconnect. In some cases disconnection was after 5 mins.

We are not going to debug openssl. thus we can ignore these warnings. this will make build output more clean.

If part of the file was added to the index and some part of it is still red (modified, but not in index) then pre-commit hook will grab the whole file into the commit.

• CMakeLists.txt files refactoring
• cmd files refactoring
• Delete environment variables usage if possible
• Make 3rd party paths and environment variables consistent

On start SDL we get 'QIODevice::open: File access not specified' and 'QFSFileEngine::open: No file name specified' warnings.

A lot of Qt warnings present in log:
QSqlQuery::value: not positioned on a valid record
See attached log file
SmartDeviceLink.txt

Rewrite LogLevel next way

namespace LogLevel {
  enum Type {
    LOGLEVEL_TRACE
    .....
  };
}

And fix usage
Currently each logging macros generates the warning regarding enum usage.

IsCertificateUpdateRequired method should be called during starting of new session with mobile device. This method uses the due date of certificate. In case SDL doesn't have certficate at all there is nothing to check and method all the time returns true since the variable which we use to store certificate time contains default value (01/01/1900).

To avoid such problem SDL uses certificate_exists_ flag in order to understand if certificate has been set to the SSL context. Using this flag currently workable but error prone solution. So we need to figure out how to implement proper check for certificate date.

• Remove class DateTime and declare all functions just in date_time namespace
• Rework getCurrentTime() function in Qt version because it works incorrectly
• timeval struct uses in Qt version is not crossplatform
• Analyze all related functions for useless and redundant

Currently we create release builds manually. It's easy to forget to update files (Policy.dll) or some other file. It would be nice to have a script (cmd or python) in infrastructure which will build and copy output files to some place. This will allow to reduce the possibility to include into release wrong files.

src/components/utils/src/rwlock_win.cc:117
(Try to acquire lock)

It uses posix close function to close the socket. There are already a lot of CloseSocket functions in anonymous namespaces. We should extract some util function and reuse it.

This flag was added because there an issue in the smart object module. Without this flag the project will not compile.
But this is hiding the real problem but not fix.
we should fix the real problem. currently we have two link warning. One in smart object(real problem) and the another because of this force flag.
/INCREMENTAL:NO flag is also related to this issue. It's not needed.