Coder Social home page Coder Social logo

Comments (2)

malirod avatar malirod commented on August 30, 2024

CryptoManagerImpl::set_certificate should be refactored. The first half of the method which doesn't change the invariant of the CryptoManagerImpl should be extracted.

starting from the SSL_CTX_use_certificate call the CryptoManagerImpl invariant changes. This should be handled correctly.
Currently it's possible that during first call of the set_certificate the certificate_exists_ wil lbe set to true. But on the second call, during the SSL_CTX_use_certificate call or after we will exit the method. and the flag will be still true. There is no reset before the calls which can change the invariant.

Also it's clear is what is going on with the CryptoManagerImpl invariant after the failed call of the SSL_CTX_check_private_key. Possibly the CryptoManagerImpl becomes invalid, thus there should be some additional handling. Possibly just write to the log and exit is not enough.

from sdl_core_winport.

malirod avatar malirod commented on August 30, 2024

Resolved with #131

from sdl_core_winport.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.