Comments (2)
CryptoManagerImpl::set_certificate
should be refactored. The first half of the method which doesn't change the invariant of the CryptoManagerImpl should be extracted.
starting from the SSL_CTX_use_certificate
call the CryptoManagerImpl invariant changes. This should be handled correctly.
Currently it's possible that during first call of the set_certificate the certificate_exists_ wil lbe set to true. But on the second call, during the SSL_CTX_use_certificate call or after we will exit the method. and the flag will be still true. There is no reset before the calls which can change the invariant.
Also it's clear is what is going on with the CryptoManagerImpl invariant after the failed call of the SSL_CTX_check_private_key. Possibly the CryptoManagerImpl becomes invalid, thus there should be some additional handling. Possibly just write to the log and exit is not enough.
from sdl_core_winport.
Resolved with #131
from sdl_core_winport.
Related Issues (20)
- Use Pimpl class in Socket and RWLock
- Implement wrapper for std::fstream to allow using Qt streams HOT 1
- Refactor DateTime class HOT 2
- Create script which will prepare the release builds HOT 2
- SDL inserts incorrect delimiters to file paths HOT 1
- Verify the version of the clang-format in the pre-commit hook
- HMI looses connection to the mobile after some time
- Change the interface of the Pipe::Send and Socket::Send HOT 1
- QSqlQuery warnings in log HOT 1
- Bug in pre-commit hook. Partial file commit doesn't work
- Check WIN_NATIVE and QT_PORT build with enabled TimeTester HOT 1
- Wrap logging level enum with namespace to fix compilation warnigs
- Fix 'QIODevice::open: File access not specified' for the Qt branch HOT 1
- Logging from policy dll doesn't work
- Qt port doesn't read correctly permissions from the db
- TcpServerOiginatedSocketConnection::Establish is not ported to windows
- There are a lot of warnings regarding missing pdb files for the openssl libs. We can ingore this. HOT 2
- cache_manager(Policy) has map with too long name (CalculatedPermissions) HOT 1
- Remove `/FORCE:MULTIPLE` linker flag from smartDeviceLinkCore cmake file HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sdl_core_winport.