lunarclient / apollo Goto Github PK

In the wiki is present a field called .icon(SimpleResourceLocationIcon) however it doesn't exist in the builder itself

Current builder for notifications:

    Notification(String title, String description, String resourceLocation, Duration displayTime) {
        this.title = title;
        this.description = description;
        this.resourceLocation = resourceLocation;
        this.displayTime = displayTime;
    }

Checklist before creating an issue:

• I'm using the latest version of Apollo.
• I'm using the latest version of Lunar Client. (Relaunched in the last hour)
• I'm running Apollo on ONLY the backend server OR the proxy. (YOU CANNOT RUN IT ON BOTH)
• I do NOT have both Apollo and the LEGACY API installed on the same server. (YOU CANNOT RUN BOTH AT THE SAME TIME)
• I've gathered all screenshots, logs and appropriate information related to creating a bug report.

Issue Description

The Glow Module, as described using the documentation, doesn't apply a glow with most colors, and for other colors it just display a black screen to the player that tries to see the glowing player.

I've also tried compiling the bukkit-example folder and use the /glow override command and it still didn't work properly.

Reproduction steps

1. Compile the bukkit-example plugin
2. Use it on a 1.8.9 paper / spigot server
3. Use the /glow override <player> command
4. The screen gets black whenever the client tries to look at the glowing player

Versions

1.8

Platforms

Spigot / Bukkit

Server Version

1.8

Modules

Optifine

Screenshots

No response

Contact Information

Discord - soladev

Additional Context

No response

I was wondering what was updated in the Lunar Client itself on 1.20.1; when you use the Fabric option the Apollo plugin no longer takes effect like it does on 1.20.4 Fabric. Anything change?

Server Version: 1.20.1
Plugin Version 1.0.8

Hi! I'm starting an SMP server and I'm hoping to disable the "minimap" mod. It's a Paper server, so I downloaded the Bukkit jar file for Apollo and added it. No matter what I do, the changes I make in the mods.yml file have no effect on the server. In most cases, when I restart the server to try and add those changes, it clears everything I've written and sets it back to default (despite me saving my work).

All I want to do is disable the minimap mod when people join my server on Lunar Client, but nothing has worked. Not sure if this is a bug or my own user error, but I've read the documentation and I'm relatively confident that I didn't screw anything up.

I'd love some advice on what else to try, and thank you for your time!

The error :

Because in method com.lunarclient.apollo.wrapper.VelocityApolloStats#getPlugins
at the line com/lunarclient/apollo/wrapper/VelocityApolloStats.java:66

We take a null value if there is no version, maybe a non-null default value should be given or change the optionality of the field "version"

When doing /apollo reload, the client is sent a OverrideConfigurableSettingsMessage for every option registered to server. Sending the client about 760 packets. Which freezes the whole game for a few seconds.

Apollo Version: 1.0.6
Lunar Version: 2.12.5-2401
Server and Client Version: 1.20.1

Packet Log of packets sent to client

All custom mod and probably module settings too are reset after a player switches servers on waterfall (might affect velocity too)

Also, gonna mention this since it will be related to fixing this issue. Can you please make it so that

1. all disabled mods are announced in one message popup instead of a seperate one for each
2. each mod change is only announced once and not with every server switch like in the old api

[05.12 23:10:13.163] INFO: [kitpvp-1] Could not pass event PlayerRegisterChannelEvent to Apollo-Bukkit v1.0.3
[05.12 23:10:13.163] INFO: [kitpvp-1] java.lang.RuntimeException: Unable to wrap value of type 'Color'!
[05.12 23:10:13.163] INFO: [kitpvp-1] at com.lunarclient.apollo.option.OptionsImpl.wrapValue(OptionsImpl.java:264) ~[?:?]
[05.12 23:10:13.163] INFO: [kitpvp-1] at com.lunarclient.apollo.network.NetworkOptions.moduleWithOptions(NetworkOptions.java:113) ~[?:?]
[05.12 23:10:13.163] INFO: [kitpvp-1] at com.lunarclient.apollo.network.NetworkOptions.sendOptions(NetworkOptions.java:88) ~[?:?]
[05.12 23:10:13.163] INFO: [kitpvp-1] at com.lunarclient.apollo.player.ApolloPlayerManagerImpl.addPlayer(ApolloPlayerManagerImpl.java:74) ~[?:?]
[05.12 23:10:13.163] INFO: [kitpvp-1] at com.lunarclient.apollo.listener.ApolloPlayerListener.onRegisterChannel(ApolloPlayerListener.java:53) ~[?:?]
[05.12 23:10:13.163] INFO: [kitpvp-1] at org.imanity.imanityspigot.executor.MethodHandleEventExecutor.execute(MethodHandleEventExecutor.java:47) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.163] INFO: [kitpvp-1] at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:78) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.163] INFO: [kitpvp-1] at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.163] INFO: [kitpvp-1] at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:524) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.163] INFO: [kitpvp-1] at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:510) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.163] INFO: [kitpvp-1] at org.bukkit.craftbukkit.v1_8_R3.entity.CraftPlayer.addChannel(CraftPlayer.java:1159) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.163] INFO: [kitpvp-1] at net.minecraft.server.v1_8_R3.PlayerConnection.a(PlayerConnection.java:2511) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.163] INFO: [kitpvp-1] at net.minecraft.server.v1_8_R3.PacketPlayInCustomPayload.a(PacketPlayInCustomPayload.java:39) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.163] INFO: [kitpvp-1] at net.minecraft.server.v1_8_R3.PacketPlayInCustomPayload.a(PacketPlayInCustomPayload.java:18) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.163] INFO: [kitpvp-1] at net.minecraft.server.v1_8_R3.PlayerConnectionUtils.lambda$ensureMainThread$0(PlayerConnectionUtils.java:52) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.163] INFO: [kitpvp-1] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539) ~[?:?]
[05.12 23:10:13.163] INFO: [kitpvp-1] at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]
[05.12 23:10:13.163] INFO: [kitpvp-1] at org.imanity.imanityspigot.thread.TickTask.run(TickTask.java:18) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.164] INFO: [kitpvp-1] at org.imanity.imanityspigot.thread.ThreadHandler.executeTask(ThreadHandler.java:95) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.164] INFO: [kitpvp-1] at org.imanity.imanityspigot.thread.ThreadHandlerReentrant.executeTask(ThreadHandlerReentrant.java:25) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.164] INFO: [kitpvp-1] at org.imanity.imanityspigot.thread.ThreadHandler.executeNext(ThreadHandler.java:67) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.164] INFO: [kitpvp-1] at net.minecraft.server.v1_8_R3.MinecraftServer.executeNext(MinecraftServer.java:1931) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.164] INFO: [kitpvp-1] at org.imanity.imanityspigot.thread.ThreadHandler.awaitTasks(ThreadHandler.java:78) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.164] INFO: [kitpvp-1] at net.minecraft.server.v1_8_R3.MinecraftServer.sleepForTick(MinecraftServer.java:1904) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.164] INFO: [kitpvp-1] at net.minecraft.server.v1_8_R3.MinecraftServer.run(MinecraftServer.java:840) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.164] INFO: [kitpvp-1] at java.lang.Thread.run(Thread.java:840) [?:?]
[05.12 23:10:19.750] INFO: CloudService [uniqueId=2f596110-d153-40b5-94f2-8601cda09952 task=lobby

On the spigot config, even if i update the config file combat setting from "competitive-game" to "disable-miss-penalty" the setting is not working.

I can't exceed the 20 cps limit while hitting air (1.8 behavior) even with a 40 cps autoclicker:

Checklist before creating an issue:

• I'm using the latest version of Apollo.
• I'm using the latest version of Lunar Client. (Relaunched in the last hour)
• I'm running Apollo on ONLY the backend server OR the proxy. (YOU CANNOT RUN IT ON BOTH)
• I do NOT have both Apollo and the LEGACY API installed on the same server. (YOU CANNOT RUN BOTH AT THE SAME TIME)
• I've gathered all screenshots, logs and appropriate information related to creating a bug report.

Issue Description

If a user switches server in velocity , the transfer request does not show up on the client.

Reproduction steps

1. Join the velocity instance
2. Switch server ( i.e from lobby to a game mode )
3. Send a transfer request

Versions

1.8

Platforms

Velocity

Server Version

1.8

Modules

Optifine

Screenshots

No response

Contact Information

Discord - haeimalan

Additional Context

No response

Heyo, I'm trying to add full support to LunarClient on my Paper Server using Apollo, but I can't seem to get it to recognize me as a LunarClient user in any way.
Ive already seen #65 and idk if the problem is still the same

I'm running:

• Paper 1.20.4 git-Paper-389 (latest)
• Apollo 1.0.6 (tried 1.0.7 too)

Method: player.sendMessage("Is a LunarUser? " + Apollo.getPlayerManager().hasSupport(player.getUniqueId()));

Wanting to do some stuff in JS and would like to be able to tell if a player is online on Lunar Client.

[05.12 23:10:13.163] INFO: [kitpvp-1] Could not pass event PlayerRegisterChannelEvent to Apollo-Bukkit v1.0.3
[05.12 23:10:13.163] INFO: [kitpvp-1] java.lang.RuntimeException: Unable to wrap value of type 'Color'!
[05.12 23:10:13.163] INFO: [kitpvp-1] at com.lunarclient.apollo.option.OptionsImpl.wrapValue(OptionsImpl.java:264) ~[?:?]
[05.12 23:10:13.163] INFO: [kitpvp-1] at com.lunarclient.apollo.network.NetworkOptions.moduleWithOptions(NetworkOptions.java:113) ~[?:?]
[05.12 23:10:13.163] INFO: [kitpvp-1] at com.lunarclient.apollo.network.NetworkOptions.sendOptions(NetworkOptions.java:88) ~[?:?]
[05.12 23:10:13.163] INFO: [kitpvp-1] at com.lunarclient.apollo.player.ApolloPlayerManagerImpl.addPlayer(ApolloPlayerManagerImpl.java:74) ~[?:?]
[05.12 23:10:13.163] INFO: [kitpvp-1] at com.lunarclient.apollo.listener.ApolloPlayerListener.onRegisterChannel(ApolloPlayerListener.java:53) ~[?:?]
[05.12 23:10:13.163] INFO: [kitpvp-1] at org.imanity.imanityspigot.executor.MethodHandleEventExecutor.execute(MethodHandleEventExecutor.java:47) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.163] INFO: [kitpvp-1] at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:78) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.163] INFO: [kitpvp-1] at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.163] INFO: [kitpvp-1] at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:524) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.163] INFO: [kitpvp-1] at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:510) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.163] INFO: [kitpvp-1] at org.bukkit.craftbukkit.v1_8_R3.entity.CraftPlayer.addChannel(CraftPlayer.java:1159) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.163] INFO: [kitpvp-1] at net.minecraft.server.v1_8_R3.PlayerConnection.a(PlayerConnection.java:2511) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.163] INFO: [kitpvp-1] at net.minecraft.server.v1_8_R3.PacketPlayInCustomPayload.a(PacketPlayInCustomPayload.java:39) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.163] INFO: [kitpvp-1] at net.minecraft.server.v1_8_R3.PacketPlayInCustomPayload.a(PacketPlayInCustomPayload.java:18) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.163] INFO: [kitpvp-1] at net.minecraft.server.v1_8_R3.PlayerConnectionUtils.lambda$ensureMainThread$0(PlayerConnectionUtils.java:52) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.163] INFO: [kitpvp-1] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539) ~[?:?]
[05.12 23:10:13.163] INFO: [kitpvp-1] at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]
[05.12 23:10:13.163] INFO: [kitpvp-1] at org.imanity.imanityspigot.thread.TickTask.run(TickTask.java:18) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.164] INFO: [kitpvp-1] at org.imanity.imanityspigot.thread.ThreadHandler.executeTask(ThreadHandler.java:95) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.164] INFO: [kitpvp-1] at org.imanity.imanityspigot.thread.ThreadHandlerReentrant.executeTask(ThreadHandlerReentrant.java:25) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.164] INFO: [kitpvp-1] at org.imanity.imanityspigot.thread.ThreadHandler.executeNext(ThreadHandler.java:67) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.164] INFO: [kitpvp-1] at net.minecraft.server.v1_8_R3.MinecraftServer.executeNext(MinecraftServer.java:1931) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.164] INFO: [kitpvp-1] at org.imanity.imanityspigot.thread.ThreadHandler.awaitTasks(ThreadHandler.java:78) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.164] INFO: [kitpvp-1] at net.minecraft.server.v1_8_R3.MinecraftServer.sleepForTick(MinecraftServer.java:1904) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.164] INFO: [kitpvp-1] at net.minecraft.server.v1_8_R3.MinecraftServer.run(MinecraftServer.java:840) ~[paper.jar:git-iSpigot-PaperEdition]
[05.12 23:10:13.164] INFO: [kitpvp-1] at java.lang.Thread.run(Thread.java:840) [?:?]
[05.12 23:10:19.750] INFO: CloudService [uniqueId=2f596110-d153-40b5-94f2-8601cda09952 task=lobby

Normally tnt that gets ignited by other explosions will have a shorter fuse time. However when the tnt countdown module is enabled in this plugin, all tnt will always have the same fuse time:

Using the old LC-API I was able to send multiple LCTitlePacket(s) as TitleType.SUBTITLE to create a smooth "zoom effect" by increasing the scale by a little for each packet, i tried to switch to the new API but for some reason the using of small scale isn't available, is this a wanted regression or is there any other reason this is being limited?