Coder Social home page Coder Social logo

Comments (3)

wkentaro avatar wkentaro commented on August 27, 2024

And I'd like to know what made you to use multiple requirements.txt files, and their combination:

add_custom_command(OUTPUT ${generated_requirements}
COMMAND ${CATKIN_ENV} ${PYTHON_EXECUTABLE} ${catkin_virtualenv_CMAKE_DIR}/combine_requirements.py --requirements-list ${requirements_list} --output-file ${generated_requirements}
DEPENDS ${requirements_list}
)

from catkin_virtualenv.

paulbovbel avatar paulbovbel commented on August 27, 2024

What motivated me to use multiple requirements files was the idea that you could have:

  • package A implement library code that depends on external library B
  • package C on package A, and inherit package A's requirement of library B transparently

I agree, the current implementation is fairly limited. It would certainly be possible to add support for other combination of constraints here.

  • The combinatorial explosion would probably require taking a different approach than currently used
  • A cleaner way would probably be to rely on the ability of requirements files to recursively include requirements files, letting pip/setuptools handle the messy resolution.

from catkin_virtualenv.

paulbovbel avatar paulbovbel commented on August 27, 2024

That was fairly easy, and I got to remove a bunch of code! #15

EDIT: closing the associated PR, not a good strategy. A better requirement-constraint-merging strategy should be implemented in catkin_virtualenv, unless pip changes the way it works with duplicated requirements.

from catkin_virtualenv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.