Comments (10)
I suspect that the reason this was added to is to allow users to mitigate for vulnerabilities linked below without having to set a new master Ledger seed. Renaming from "Account" to "Wallet" as shown in selsta's pull request #96 would be ideal.
CVE-2020-6861: Ledger Monero App Spend key Extraction
from app-monero.
@selsta completely agree.
from app-monero.
Makes sense to remove this. If someone really wants multiple distinct accounts, they can just use the device's additional passphrase / PIN feature.
from app-monero.
Considering that some people already use this feature, removing is probably not going to work :/ I would still like renaming + adding an extensive warning.
from app-monero.
The additional passphrase / PIN feature is similar to accounts in that it grants you access to a completely different wallet.
As example, when you're in a wallet using say, Bitcoin Electrum + ledger, and you let the ledger device go to sleep, then wake it up, you'll be granted with a passphrase/PIN prompt - you now have 2 options:
- Enter wallet passphrase
- Enter global PIN
Depending on which passhprase/PIN you enter, you open a different wallet on the Ledger. However, Electrum still thinks you're on the old one - there will be weird wallet behavior. This is also observed over at Monero, both GUI and CLI.
Anyway, this issue is about the naming, or removal of accounts - I'm in favor of any of those two options.
from app-monero.
I agree that we should rename the feature in the Monero application.
Any suggestions?
from app-monero.
I have a question that might fit here, the Seed Recovery is possible for accounts different than n0 as well with the blue-app-monero tools? i second that this should be either renamed or better explained btw, it's quite confusing currently
from app-monero.
Using the derivation path can be good practice in other coins but NOT Monero. Since GUI Wallet, or other wallet interface does not provide you that option directly, recovering such wallets can be super hard -- you will need to generate priv/pub keys using other tools that takes derivation path. (too much tech details for an average user to figure out!)
Monero's official "subaddress" solution is hierarchical, but it is not about BIP derivation path also but it is using its own major:minor (account/address) derivation.
Also, this feature is not well documented, look at this: I googled "ledger monero doc" and the first result official result tells me nothing about this menu entry.
I suggest we rename the "account" here to "wallet" and prompt user in ledger app that it is a legacy feature. (don't forget to update docs too! IMO Ledger Support always has the best user-accessibility and should definitely document this.)
from app-monero.
@typh289 I'm afraid not, look at this:Source Code, the devs hard-coded the derivation path u"m/44'/128'/0'/0/0" so it will only generate words of XMR/0.
from app-monero.
@typh289 however if you use online mode to show 25 word seed on your device, the 25 word seed is account number specific (every 'account' has their own 25 word seed). since the code on ledger uses master seed of monero-app which is generated with different derivation path (different account' value) on initialization.
from app-monero.
Related Issues (20)
- two different seeds generated from the same ledger using the python script HOT 6
- Balance on Mondero GUI is Not Showing HOT 5
- Where is tools/python/ in mac HOT 1
- Application and ledger device crash...
- Can't read Monero Elect keywords with "online mode" HOT 2
- Ledger stuck on "Preparing TX"
- How to get monero?
- Can't open [Getting Started]
- Impossible to create an HW wallet wtih monero GUI HOT 2
- ledger.monero.seedconv creates a different 25 word seed from ledger HOT 2
- seedconv.py online failing with "No module named 'ledger'" HOT 1
- Ledger Nano X wrong device status after upgrading to 0.17.0.1 HOT 3
- Cannot open view-only wallet
- Only way to recover by seed phrase is to compile app manually? HOT 2
- pip install readline fails for blue-app-monero tool on MacOS Catalina 10.15.7 HOT 4
- Device not found HOT 19
- Transfer from MyMonero to MoneroApp in Ledger. HOT 11
- Spelling error - looks sloppy in UI
- Seed Recovery Fails HOT 1
- Status of new function implementations
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from app-monero.