lascic / uionboarding Goto Github PK

UIOnboardingHelper.swift:34: Fatal error: Unexpectedly found nil while unwrapping an Optional value

Is there a way to configure away the text generated by setUpNotice()? I just don't need this text.

 static func setUpSecondTitleLine() -> NSMutableAttributedString {
        .init(string: Bundle.main.displayName! ,  attributes: [
         
            .foregroundColor: UIColor(Color.TintColor) ,
            .font : UIFont(name: "MADECanvas", size: 16)!,
        ])
    }

The font is found as I got no crash

Any possibility to change the background color of the safe area?

Tried multiple techniques with makeUIViewController and updateUIViewController without success.

Greetings,

Hi - so i have this problem:
I only want to have the button at the bottom, not a text or other stuff, but the size around the button still is HUGE - could you fix this?

Get this error:
UIOnboardingHelper.swift:9:8 Could not find module 'UIOnboarding' for target 'x86_64-apple-ios-simulator'; found: arm64-apple-ios-simulator, at: Build/Products/Debug-iphonesimulator/UIOnboarding.swiftmodule

I added the pkg with SPM and import the library. My code has a small stub which runs the UIOnboarding startup sequence:

    func doOnBoarding() -> Void {
        setUp()
        presentOnboarding()
    }
    
    @objc private func presentOnboarding() {
        let onboardingController: UIOnboardingViewController = .init(withConfiguration: .setUp())
        onboardingController.delegate = self
        navigationController?.present(onboardingController, animated: false)
    }

I get Error "Type 'UIOnboardingViewConfiguration' has no member 'setUp'". in the .init(withConfiguration: .setUp() )
Any thoughts?

Hello,

Upon launching the app, we got in the @main entry point:

UIOnboarding/UIOnboardingViewController.swift:94: Fatal error: Unexpectedly found nil while implicitly unwrapping an Optional value

The title label currently uses a fixed font size:

This causes the layout to break with long app names and localization. For example, replace "Welcome to" with "Willkommen bei" and run the sample project on a small iPhone.

UILabel supports automatic text scaling by setting the adjustsFontSizeToFitWidth property to true and specifying a minimumScaleFactor. Unfortunately, this only works with single-line text.

My suggestion would be to split the title into two labels ("Welcome to" and app name), enable automatic text scaling for both, and place them inside a UIStackView.

I can create a PR with this change, but would like to hear your opinion first. @lascic.

iPhone layout is perfect, however, in iPad runtime, there are multiple conflicts:

1. Probably at least one of the constraints in the following list is one you don't want.
   Try this:
   (1) look at each constraint and try to figure out which you don't expect;
   (2) find the code that added the unwanted constraint or constraints and fix it.
   (
   "<NSLayoutConstraint:0x60000031d180 UIOnboarding.UIOnboardingTitleLabel:0x7f7f5428a020.width == 904 (active)>",
   "<NSLayoutConstraint:0x600000316e40 UIOnboarding.UIOnboardingStack:0x7f7f542854b0.width == 480 (active)>",
   "<NSLayoutConstraint:0x60000032ec10 'UISV-alignment' UIOnboarding.UIOnboardingTitleLabel:0x7f7f542a1eb0.leading == UIOnboarding.UIOnboardingTitleLabel:0x7f7f5428a020.leading (active)>",
   "<NSLayoutConstraint:0x60000032ec60 'UISV-alignment' UIOnboarding.UIOnboardingTitleLabel:0x7f7f542a1eb0.trailing == UIOnboarding.UIOnboardingTitleLabel:0x7f7f5428a020.trailing (active)>",
   "<NSLayoutConstraint:0x60000032f2f0 'UISV-alignment' UIView:0x7f7f54247180.leading == UIOnboarding.UIOnboardingTitleLabelStack:0x7f7f542535a0.leading (active)>",
   "<NSLayoutConstraint:0x60000032eb20 'UISV-canvas-connection' UIOnboarding.UIOnboardingTitleLabelStack:0x7f7f542535a0.leading == UIOnboarding.UIOnboardingTitleLabel:0x7f7f542a1eb0.leading (active)>",
   "<NSLayoutConstraint:0x60000032ead0 'UISV-canvas-connection' H:[UIOnboarding.UIOnboardingTitleLabel:0x7f7f542a1eb0]-(0)-| (active, names: '|':UIOnboarding.UIOnboardingTitleLabelStack:0x7f7f542535a0 )>",
   "<NSLayoutConstraint:0x60000032ee90 'UISV-canvas-connection' UIOnboarding.UIOnboardingStack:0x7f7f542854b0.leading == UIView:0x7f7f54247180.leading (active)>",
   "<NSLayoutConstraint:0x60000032eee0 'UISV-canvas-connection' H:[_UILayoutSpacer:0x600001f5ce10'UISV-alignment-spanner']-(0)-| (active, names: '|':UIOnboarding.UIOnboardingStack:0x7f7f542854b0 )>",
   "<NSLayoutConstraint:0x60000032f160 'UISV-spanning-boundary' _UILayoutSpacer:0x600001f5ce10'UISV-alignment-spanner'.trailing >= UIOnboarding.UIOnboardingTitleLabelStack:0x7f7f542535a0.trailing (active)>"
   )

Will attempt to recover by breaking constraint
<NSLayoutConstraint:0x60000031d180 UIOnboarding.UIOnboardingTitleLabel:0x7f7f5428a020.width == 904 (active)>

(
"<NSLayoutConstraint:0x600000316e40 UIOnboarding.UIOnboardingStack:0x7f7f542854b0.width == 480 (active)>",
"<NSLayoutConstraint:0x60000031df90 UIOnboarding.UIOnboardingTitleLabel:0x7f7f542a1eb0.width == 904 (active)>",
"<NSLayoutConstraint:0x60000032f2f0 'UISV-alignment' UIView:0x7f7f54247180.leading == UIOnboarding.UIOnboardingTitleLabelStack:0x7f7f542535a0.leading (active)>",
"<NSLayoutConstraint:0x60000032eb20 'UISV-canvas-connection' UIOnboarding.UIOnboardingTitleLabelStack:0x7f7f542535a0.leading == UIOnboarding.UIOnboardingTitleLabel:0x7f7f542a1eb0.leading (active)>",
"<NSLayoutConstraint:0x60000032ead0 'UISV-canvas-connection' H:[UIOnboarding.UIOnboardingTitleLabel:0x7f7f542a1eb0]-(0)-| (active, names: '|':UIOnboarding.UIOnboardingTitleLabelStack:0x7f7f542535a0 )>",
"<NSLayoutConstraint:0x60000032ee90 'UISV-canvas-connection' UIOnboarding.UIOnboardingStack:0x7f7f542854b0.leading == UIView:0x7f7f54247180.leading (active)>",
"<NSLayoutConstraint:0x60000032eee0 'UISV-canvas-connection' H:[_UILayoutSpacer:0x600001f5ce10'UISV-alignment-spanner']-(0)-| (active, names: '|':UIOnboarding.UIOnboardingStack:0x7f7f542854b0 )>",
"<NSLayoutConstraint:0x60000032f160 'UISV-spanning-boundary' _UILayoutSpacer:0x600001f5ce10'UISV-alignment-spanner'.trailing >= UIOnboarding.UIOnboardingTitleLabelStack:0x7f7f542535a0.trailing (active)>"
)

Will attempt to recover by breaking constraint
<NSLayoutConstraint:0x60000031df90 UIOnboarding.UIOnboardingTitleLabel:0x7f7f542a1eb0.width == 904 (active)>

The following error occurs:
UIOnboarding/UIOnboardingViewController.swift:98: Fatal error: Unexpectedly found nil while implicitly unwrapping an Optional value

Hey there,

I don't know how easily you could implement this, but it would be a very nice option to make the subtitle text of each bullet point a bit smaller.
Currently, it's the same size as the title above it, just not bold.
I'd love to see a size different or at least an option for it.

If this is too much hassle due to the sizing adjustments necessary, I'd understand it.

Thanks in advance
P.S.: I love your repo, this Onboarding View is awesome!!

the library is very cool, but I felt like it requires way too much code to just make it look like apple, and I wish there was just native swiftui support rather than using UIkit

Hi, I love this project but would kindly suggest that an example is chosen that doesn't appear to endorse military. Thanks

Are you planning to add SF Symbol support?

Will it support setting background color in the future as mentioned above? Thank you 🙏

Hey,

I noticed, that when you put an image into the notice area, it doesn't get properly resized and is way too big.
The images next to the bullet points get resized to fit, but the notice image is shown as is.

The only fix right now is manually downsizing the image, but it should work as it does with all other images.

Example:

I just wanted to let you know.
I will see when I fix my issue. I can figure out why its is crashing. As of now I have this