Comments (2)
My initial thought when first building UIOnboarding was that the order between the app name and "Welcome to" could be in reversed or mixed order for some other languages, for which I let other developers decide how to name it in only one single NSMutableAttributedString
and UIOnboardingLabel
instance.
Another thought behind this was that in Apple's Stocks onboarding screen the title label always has only two lines, regardless of Dynamic Type setting or not. And this is something I want to stick with UIOnboarding. Let's assume we have the label's text size set to XXXL in Dynamic Type on an iPhone SE (1st generation). First, it would have too many lines and second, the words would be clipped which is hard for users to read. I can imagine it to look too big to read during the short time where the app icon and app name label get animated in the beginning.
Since we have layout issues with line breaks I'd say we do it the way you suggested – which sounds good to me. Only thing I'd like to keep is the two line restriction with the fixed font size alongside adjustsFontSizeToFitWidth
toggled (the font size of both labels in that stack view should be identical in any case with adjusted line spacing) and a minimumScaleFactor
set.
from uionboarding.
Hi @lascic,
Thank you for sharing your thoughts. I've added the first draft of my implementation to PR #4. The changes are currently only included in the "UIOnboarding Demo" project.
I haven't found a solution for the requirement yet that the two labels should always have the same font size. As far as I know, UILabel
does not update its fontSize
property when it scales down the text. I assume we would have to calculate the largest possible font size manually and apply it to both labels. That would defeat the main purpose of the automatic scaling, though.
If you have any other ideas, please let me know. You can also make changes to the code in my PR directly. Thanks! 👌
from uionboarding.
Related Issues (18)
- Multiple Constrains / Layout Failure in iPad (12.9) HOT 11
- Possibility to have empty setUpNotice()? HOT 2
- Safe area UI HOT 1
- Custom Font not working HOT 7
- Configure the height of the button layer HOT 3
- Error when executing app in Xcode 15 beta / iOS 17 HOT 5
- Doesn't compile on M1/M2 using SPM HOT 3
- iOS 17 Crash HOT 1
- Null Error on Xcode 15
- SF Symbol Support HOT 1
- No support onboardingScrollView update "BackgroudColor"
- Existing codebase is crashing on Xcode 16 developer beta.
- Cool but tedious to implement
- Non-military example? HOT 1
- Image in notice area too big HOT 2
- Enhancement: Adjust Font size HOT 2
- Compile Error HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from uionboarding.