Coder Social home page Coder Social logo

fvtt-custom-dnd5e's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

fvtt-custom-dnd5e's Issues

[FEATURE] Actor Counters

Allow users to add counters to an actor. Useful for tracking stuff that is specific to that actor, such as, number of kills.

Languages Disappear [BUG]

Describe the bug

Languages disappear, leaving only a few that don't work - and the languages that do show after I thought I fixed it by entering all the languages again show as random characters after leaving and coming back. It showed the random characters to the players as well.
It might be a possible conflict with polygot? Or perhaps its from me adding languages, or trying to remove one not used in my game?
image

Module Data
custom-dnd5e.json

[FEATURE] Apply Massive Damage

Add an option to request a Constitution saving throw when a character takes Massive Damage. Optionally auto-roll on the System Shock table.

[BUG] Same Key on Character and NPC Counter

Describe the bug

  1. There is currently no validation for counter keys to check whether it already exists. If this happens, it will cause breaking errors.
  2. It would be useful to allow a character counter and an NPC counter to share a key where the function of the counter is the same, for example, an Exhaustion counter for both characters and NPCs.

Fix for 1. is to validate key against existing keys when the user clicks Save and Close and stop the form submission if the key is the same as an existing key. Fix for 2. is to allow duplicate keys across character and NPC counters and either add the actor type to the field name in the counters form or handle the arrays created.

Steps to reproduce

  1. Edit the key for a character counter
  2. Edit the key for an NPC counter to be the same key
  3. See error

Versions:

  • Module: 0.7.0
  • System: dnd5e 3.0.3
  • Foundry VTT: 11.315

[FEATURE] Counter Trigger Chat Notification

Describe your idea
Add option to send a notification to chat when a counter trigger occurs. For example, for an Exhaustion counter, when the character reaches 0 HP, a notification is sent to chat saying something like: 'Bilbo's Exhaustion has increased to 1'.

[BUG]

Custom Skills are not populated

If you have a Custom Skill independent where its created, inside the module or through for example Rippers system customizer it is not populated into the Character sheet and as such breaking the character,

Module Data

custom-dnd5e.json

Steps to reproduce

  1. Go to Module settings and create a Custom Skill
    image

  2. Open Character Sheet

  3. Notice the lack of the skill
    image

  4. ....

Versions:

  • Module: [e.g. 0.11.1]
  • System: [e.g. dnd5e 3.0.4]
  • Foundry VTT: [e.g. 11.315]
  • Browser: [e.g. Google Chrome 121.0.6167.161]

Additional context
As I Use a few custom skills module is unusable.

[BUG] Counter Issues

Hi there,

I noticed as of the most recent update 0.7.2, counters are being wonky. Wasn't having issues before. It wasn't letting me add a maximum value for fractions and was just generally being weird. I can't really describe it any better and for my next issue will be obvious why. I can no longer edit counters as an option. I get this error in the console:

undry.js:753 TypeError: An error occurred while rendering CountersForm 474. key.split is not a function or its return value is not iterable
[Detected 1 package: custom-dnd5e]
at Object.getProperty (commons.js:2536:24)
at Localization.localize (foundry.js:7586:27)
at Object.localize (foundry.js:7962:52)
at Object.c (handlebars.min.js:27:19853)
at eval (eval at createFunctionContext (handlebars.min.js:29:1808), :31:149)
at h (handlebars.min.js:27:17870)
at c (handlebars.min.js:27:6899)
at handlebars.min.js:27:7554
at Array.forEach ()
at handlebars.min.js:27:7522
at Object. (handlebars.min.js:27:7597)
at Object.c (handlebars.min.js:27:19853)
at Object.eval [as main] (eval at createFunctionContext (handlebars.min.js:29:1808), :11:49)
at c (handlebars.min.js:27:15429)
at d (handlebars.min.js:27:15744)
at e (handlebars.min.js:28:22748)
at Object.h (handlebars.min.js:27:18738)
at Object.c [as invokePartial] (handlebars.min.js:27:15036)
at Object.eval [as main] (eval at createFunctionContext (handlebars.min.js:29:1808), :17:28)
at c (handlebars.min.js:27:15429)
at d (handlebars.min.js:27:15744)
at e (handlebars.min.js:28:22748)
at renderTemplate (foundry.js:7743:10)
at async CountersForm._renderInner (foundry.js:5973:16)
at async CountersForm._renderInner (foundry.js:6543:18)
at async CountersForm.renderPatch (application-render.js:38:19)
at async CountersForm._render (foundry.js:6532:5)

I am basically stuck with counters on the sheets that I can't configure. I can still click em to increase or decrease, but I can't access them in the module settings.

Any help would be appreciated, love the module.

Thanks,
Drafty

[BUG] Error 'undefined reading ('children')' when Opening Character Sheet

Describe the bug
Having the module enabled causes character sheets to be unable to open.
image

Steps to reproduce

  1. Have module enabled
  2. Attempt to open player character sheet.

Versions:

  • Module: [0.4.0]
  • System: [dnd5e 3.0.1]
  • Foundry VTT: [11.315]
  • Browser: [Chromium 121.0.6167.161]

Additional context
I have tried disabling all modules but this one and libwrapper.

[FEATURE] Custom Key Mapping

Describe your idea
A way to set the key of a counter so you can keep them the same across games. This way Macros and Effects can be used in different games without the need to change anything.

[BUG] Maximum call stack size exceeded

Describe the bug
Logger.debug() causes call stack errors. It calls getSetting() which calls Logger.debug() which calls... until the call stack throws an error.

Versions:

  • Module: fvtt-custom-dnd5e 0.5.0
  • System: dnd5e 3.0.2
  • Foundry VTT: 11.315 (Stable)
  • Browser: built-in

Additional context

utils.js:18 Uncaught (in promise) RangeError: Maximum call stack size exceeded
    at Logger.debug (utils.js:18:9)
    at getSetting (utils.js:111:16)
    at Logger.debug (utils.js:18:30)
    at getSetting (utils.js:111:16)
    at Logger.debug (utils.js:18:30)
    at getSetting (utils.js:111:16)
    at Logger.debug (utils.js:18:30)
    at getSetting (utils.js:111:16)
    at Logger.debug (utils.js:18:30)
    at getSetting (utils.js:111:16)

[BUG] Error when Setting `encumbrance.value` for NPC Actor

Describe the bug
Caused by NPC actors not having encumbrance properties. Fix is to check for actor type and only proceed for characters.

Steps to reproduce

  1. Open an NPC actor sheet
  2. See error

Versions:

  • Module: 0.7.0
  • System: dnd5e 3.0.3
  • Foundry VTT: 11.315

Additional context
image

[BUG] Missing Checkboxes

Hi! A big thanks for the module. I have a problem with the checkboxes (magical and weightless) in the new containers being invisible with the last version of custom D&D. Everything is updated but they are simply not there.

Disabling the module returns the boxes.

Details

[FEATURE] Death at Max Value Counter Setting

Add a counter setting to automatically set an actor to 0 HP and add the Dead condition to the actor's token when the counter reaches its max value. For example, a counter to reflect the D&D 2024 Playtest' Exhaustion mechanic.

Possibly add a confirmation dialog and/or a chat message to signpost the event.

[FEATURE] Roll a Number Counter Trigger

Add a counter trigger for rolling a specific number, such as 1 or 20 on a d20 or 6 on a d6. This would allow for things like gaining Inspiration on rolling a 1 on a d20 or recharging an ability.

[FEATURE] Add Threatened condition

Add a Threatened condition to indicate when a character could be targeted by an opportunity attack. Automate application based on distance to enemy tokens.

[BUG] replaces all base damage with [object Object]

Describe the bug
damageroll
dae
all base dnd damage types are replaced with [object Object] as a name. MidiQoL applies damage normally but the damage name is changed.

Versions:

  • Module: 0.8.1
  • System: dnd5e 2.4.1
  • Foundry VTT: 11.315

[BUG] Configure Item Properties adds all properties to Equipment

Describe the bug
Every single property within the configure item properties has the equipment box checked. Trying to uncheck the boxes and applying the change does not work as all the properties have the boxes checked still.

Item Property Window Resulting Equip Mess

Steps to reproduce

  1. Go to Configure Item Properties
  2. Click on Reset to Default
  3. Click save and close
  4. Return to Configure Item Properties
  5. Uncheck the equipment boxes
  6. Click save and close
  7. Return to Configure Item Properties
  8. See Error

Versions:

  • Module: [e.g. 0.5.1]
  • System: [e.g. dnd5e 3.0.2]
  • Foundry VTT: [e.g. 11.315]

[FEATURE] Append information to inventory/features/spellbook tables

Append information in the inventory, features and spellbook tables to show additional property information.
e.g,. adding attack roll and damage formula to a row for a weapon.

I attempted this, but the current .css for these tables is really terrible to do alignments. See image.

image

[FEATURE] Add Small Form Factor Character Sheet

Duplicate and modify the core dnd5e character sheet to provide a smaller version. Make it selectable from the Sheet Configuration rather than just a module setting to modify the existing CSS.

  • Reduce header
  • Shrink ability score boxes to allow additional ones can go on the same line
  • Reduce padding
  • Allow width to be reduced by moving or removing elements

[BUG] Cannot open character sheet

Describe the bug
Cannot open character sheets with fvtt-custom-dnd5e active. All settings are default.

Versions:

  • Module: fvtt-custom-dnd5e 0.5.0
  • System: dnd5e 3.0.2
  • Foundry VTT: 11.315 (Stable)
  • Browser: Built-in

Additional context

TypeError: An error occurred while rendering ActorSheet5eCharacter2 42. Cannot read properties of undefined (reading 'children')
[Detected 3 packages: system:dnd5e, custom-dnd5e, lib-wrapper]
    at searchCategory (trait.mjs:452:16)
    at searchCategory (trait.mjs:453:26)
    at keyLabel (trait.mjs:458:20)
    at character-sheet-2.mjs:434:32
    at Array.map (<anonymous>)
    at ActorSheet5eCharacter2._prepareTraits (character-sheet-2.mjs:433:23)
    at ActorSheet5eCharacter2.getData (base-sheet.mjs:180:27)
    at ActorSheet5eCharacter2.getData (character-sheet.mjs:24:33)
    at ActorSheet5eCharacter2.getData (character-sheet-2.mjs:183:33)
    at ActorSheet5eCharacter2.renderPatch (application-render.js:28:29)
    at 🎁call_wrapper [as call_wrapper] (libWrapper-wrapper.js:591:14)
    at 🎁Application.prototype._render#0 (libWrapper-wrapper.js:189:20)
    at ActorSheet5eCharacter2._render (foundry.js:6532:17)
    at ActorSheet5eCharacter2._render (character-sheet-2.mjs:170:17)
    at ActorSheet5eCharacter2.render (foundry.js:5769:10)
    at ActorSheet5eCharacter2.render (foundry.js:7111:18)
    at ActorDirectory._onClickEntryName (foundry.js:70219:20)
    at HTMLOListElement.dispatch (jquery.min.js:2:43184)
    at y.handle (jquery.min.js:2:41168)

[FEATURE] Blind Death Saves

Allow player to click to roll a death save, but make the roll blind and hide the result from the player by hiding the pips on the death save tray.

[FEATURE] Bloodied Condition

Add option to enable a bloodied condition when the character reaches half HP. Automaticslly apply an effect and maybe add a condition for manual toggling.

[BUG] NPC Fraction Counter

Describe the bug
Counters on NPCs do not appear to work when set to fractions. I am currently using 0.8

[BUG]

Describe the bug

A description of the bug and any screenshots.
If you change tokens with a character sheet open and then change them back to another token type with the sheet open you can break a character sheet by causing an error. Likely because the old character sheet did not change.

Module Data
custom-dnd5e.json

Go into the module's settings, open up the Debug Settings menu, click Export Data, save and attach the file here.

Steps to reproduce

  1. Create a token
  2. open a character sheet
  3. modify that state with the character sheet open
  4. Then modify the token with the sheet open
  5. Then change it back to another token type
  6. Then close the character sheet
  7. You likely won't be able to reopen it

Versions:

  • Module: 1.0
  • System: [e.g. dnd5e 2.4.1]
  • Foundry VTT: V11 stable
  • Browser: Firefox

Additional context
Any additional context.

[BUG] Actor sheet randomly opening for GM/Players

Hi there,

Kind of confusing to explain but, when a a player or the GM interacts with a character sheet, it will force the sheet to open on the other side. So for instance if delete an item off of a player's sheet, their sheet will open up on their screen even if it wasn't open before. Same thing goes if a player would delete an item, opens on the GM side. It also does this if you change the quantity of a charge or item.

If a player has limited access, it still pops up for them as well.

I also just noticed if you try to apply a class to a sheet and go through the advancement, it won't let you go past selecting average or rolled hit points.

I can try and elaborate further if needed. Love the module.

Thanks!
Drafty

Versions:

  • Module: [0.4.0]
  • System: [dnd5e 3.0.2]
  • Foundry VTT: [e.g. 11.315]
  • Browser: [e.g. Google Chrome 121.0.6167.161]

[BUG] Disappearance of item and spell components

The issue is simple.
Using latests Foundry & Latests Dnd 5e module, try to activate this module and look at your items and spells.
None of them has the components stuff there anymore nor can you see the old ones, they simply disappear which i think its pretty problematic :S.
image

that the before

image

this is the after.
as you can see it loses all the "concentration" or "verbal" stuff.
any fix planned? module seems pretty nice and useful in the future ^^

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.