konmik / solid Goto Github PK

(this is more like a feature request)

I ran across this library and I would like to start using this. However the library supports only List and Map but not Set, which can be very useful for different use cases.

I wonder if it's possible for you to add Set implementation any time soon?

https://medium.com/the-wtf-files/the-mysterious-case-of-the-bundle-and-the-map-7b15279a794e

SolidSet can't be compared with equals to other Set implementations, although SolidList can.

Was reading autovalue builders collections, and tried using a List in the Builder to populate my SolidList, then read Solid Collections > Details, so I switched the Builder's List to ArrayList, but got the error message:
Error:(25, 33) error: Parameter type of setter method should be solid.collections.SolidList<java.lang.String> to match getter com.test.autovalue.Element.names

@AutoValue
abstract class Element {

    public abstract SolidList<String> names();

    public static Builder builder(){
        return new AutoValue_Element.Builder();
    }

    @AutoValue.Builder
    public abstract static class Builder{
//        public abstract Builder names(SolidList<String> value); // works
        public abstract Builder names(ArrayList<String> value); // doesn't
        public abstract Element build();
    }
}

Hello, @konmik! Yes we use Solid 😸

At the moment to create SolidList of values you need to either use new SolidList<>(asList(value1, value2)) or Stream.of(value1, value2).collect(toSolidList()))

But both variants require additional objects :(

Can we please have a way to create SolidList directly from varargs?

Hey I noticed you don't run builds on Travis or any other kind of CI (I might be missing something though). I feel like we should fix that, I would be happy to help!

Also, is there any particular reason you run instrumented unit tests (which work on device/emulator) rather than plain Junit/Robolectric tests?

I wonder why SolidList doesn't have some zip function like one in Haskell or RxJava. Here is possible implementation: link.

e.g like in groovy:

• http://docs.groovy-lang.org/latest/html/groovy-jdk/java/lang/Iterable.html#every(groovy.lang.Closure)
• http://docs.groovy-lang.org/latest/html/groovy-jdk/java/lang/Iterable.html#any(groovy.lang.Closure)