Coder Social home page Coder Social logo

lidar-avr's People

Contributors

bartekpacia avatar dsonyy avatar

Stargazers

 avatar  avatar  avatar

lidar-avr's Issues

Not handling wrong CRC

lidar-avr/lidar-avr.c

Lines 107 to 115 in 30be813

if (frame_ready && crc == frame[FRAME_SERVO_LEN - 1]) {
byte_number = 0;
frame_ready = 0;
uint16_t pwm = (frame[4] << 8) + frame[5];
if (pwm >= MIN_DUTY && pwm <= MAX_DUTY) {
OCR1A = pwm; // Set PWM TOP to received PWM duty
}
frame_ready = 0;
}

If CRC is correct, program sets servo and clears frame_ready. And in this case it works.
But if CRC is wrong, program won't enter to if, and frame_ready won't be cleared.
So program can hang when CRC will be wrong. It should be changed. If frame_ready is 1, but CRC is wrong, ignore this frame, and maybe send info about CRC error.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.