Comments (9)
Also happens for random 40kb buffer and some other files. For fewer pairity/shards (e.g 50/20) error doesn't occur. Is the likelihood of singularity rises when the size of the matrix rises?
from reedsolomon.
it seems the rows/cols idx exceeds byte len when generating Vandermonde matrix within Galois Field
https://github.com/klauspost/reedsolomon/blob/master/matrix.go#L271
from reedsolomon.
It would seem that to be safe from this the number of data+parity shards should not exceed 255.
I did some tests, which only seemed to fail if the number of data shards where >255, but it seems like there is another limitation that kicks in when reconstructing.
from reedsolomon.
Hi,
Thanks for the answer.
I think I missed the point of how to avoid this or that maybe it's a bug?
Are you saying that shards+parity cannot excced 255? Cause I didn't infer
that from the documentation. (And also there's no error for those
dimensions)
Sorry for my lack of understanding.
On Apr 10, 2016 21:30, "Klaus Post" [email protected] wrote:
It would seem that to be safe from this the number of data+parity shards
should not exceed 255.I did some tests, which only seemed to fail if the number of data shards
where >255, but it seems like there is another limitation that kicks in
when reconstructing.—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#16 (comment)
from reedsolomon.
Are you saying that shards+parity cannot excced 255?
That would be my recommendation. I will do some more tests, but for now, I would stick to that.
from reedsolomon.
Thank you very much
On Apr 10, 2016 21:50, "Klaus Post" [email protected] wrote:
Are you saying that shards+parity cannot excced 255?
That would be my recommendation. I will do some more tests, but for now, I
would stick to that.—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#16 (comment)
from reedsolomon.
AFAIK - (k + m) cannot be bigger than Galois field GF(2^8) - 1
from reedsolomon.
ok so shouldn't we add a check at the constructor?
from reedsolomon.
That would make sense, yes - as well as updating the documentation
from reedsolomon.
Related Issues (20)
- Slice bounds out of range at ReconstructData HOT 8
- replace [][]byte with []byte to reduce gogc scan time HOT 4
- Suggestion: Export Galois field arithmetic and move it to a subpackage like reedsolomon/galois HOT 2
- panic: runtime error: index out of range at Split() HOT 1
- Can we use WithLeopardGF16(true) when shards are less than 256?
- runtime error: slice bounds out of range HOT 3
- Slice bounds out of range [6400:3200] in codeSomeShardsAVXP HOT 4
- Consider introducing a new error when shard size is not a multiple of 64
- (*reedSolomon).codeSomeShardsGFNI and others should make use of defer for sync.WaitGroup operations like .Done() and .Wait() HOT 1
- How to speed up progressive encoding? HOT 6
- Encoder return the same content for many shards HOT 4
- First parameter of galDivide is always 1 HOT 9
- JS implementation HOT 1
- A
- Implement proper ReconstructSome for leopard
- `ReconstructSome` for Leopard HOT 3
- Consider allowing reconstructSome to compute parity shards
- concurrency: (*inversionTree).GetInvertedMatrix holds a read-lock before returning a slice to naked usage yet slices are mutable and without the lock hence susceptible to using the wrong data/data races HOT 2
- How does the performance compare with golang's https://github.com/klauspost/reedsolomon?
- Loading argument twice off the stack?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reedsolomon.