Coder Social home page Coder Social logo

(*reedSolomon).codeSomeShardsGFNI and others should make use of defer for sync.WaitGroup operations like .Done() and .Wait() about reedsolomon HOT 1 CLOSED

odeke-em avatar odeke-em commented on August 26, 2024
(*reedSolomon).codeSomeShardsGFNI and others should make use of defer for sync.WaitGroup operations like .Done() and .Wait()

from reedsolomon.

Comments (1)

klauspost avatar klauspost commented on August 26, 2024

Goroutines are unprotected, so a panic will crash anyway, leaving it is a bit of a non-issue.

I will change the wg.Done() - just so it isn't forgotten if a code change would return early in the future, but otherwise leave it as is.

from reedsolomon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.