kawa-oneechan / scicompanion Goto Github PK

Hi.

SQ3 crashes when trying to decompile.

Before fixing this, maybe it's possible to print some error message before it crashes out?

Thanks

I have just upgraded to a ThinkPad 490, and its native resolution (2560x1440) is not properly supported by SCICompanion - the buttons are much too small, and the text doesn't fit. Previously, I was using 1600x900, and Companion displayed fine. Here is a screenshot.

In contrast, WinAGI runs fine. At least for now, I can just switch to 1600x900 when using Companion.

When importing a MIDI file into a sound resource, the sound will play using the General MIDI, MT-32, and Adlib drivers. So far so good.
However, the sound does not play if using the PC Speaker driver, even if you manually set one (and only one!) of the tracks for it. I think it's because the sound editor doesn't flag the sounds to play through the PC speaker. This applies primarily to SCI1.1; I haven't really tested earlier versions.

I only tested it with old SCI 1.1 games, but whenever I modify the resources the filenames of RESOURCE.MAP and RESOURCE.000 are changed to lowercase, which may be problematic when the resources are used on case-sensitive operating systems.

Would it be a big issue to change it so that the character casing is kept intact?
Same for the export of patch files?

PS: I just used the latest version for some translations and it worked great (with Umlauts). Thanks again!

I'm using the latest build from here
https://github.com/Kawa-oneechan/SCICompanion/actions/runs/5442185766

and the application just straight crashes when I do that with Space Quest 1 or Space Quest 4, I guess it is unrelated to the game.

I have no logs that I could provide (or dont know where they are).

Please implement @OmerMor's suggestion, as described at https://github.com/icefallgames/SCICompanion/issues/10

The LSL3 demo is missing its selector table. No worries, I can grab the one from the full game.

However, there's a more serious issue here - when deompiling the game scripts (system scripts are unaffected), the decompiler gives every selector in code as zero! Thus, they're all called "species". This doesn't occur when looking at the disassembled scripts in SCI Viewer.

Hi.

I'm trying to check feasibility of Hebrew translation for SQ3.
When I tried to modify words to Hebrew in Vocab.000, SCICompanion errored with Words must contain only letters or numbers.
There is no reason to constrain that - maybe issue a warning, if we want to be on the safe side.

Can you remove that limit?

An example for the error:
Replace group 474 (examine | gaze | inspect | look | observe | peer | scan | stare | view) with הבט.

Just a note - it is possible to replace text resources to Hebrew.

Hi.
With the latest release, when I decompile Torin's Passage, it crashes in the middle.
With the release I downloaded 2 days ago, it's working OK.

Clean copy of QFG1VGA, decompile, and then 'compile all', fails on few scripts.
I have already reported (#11) about the problem at Rock.sc, but there are few more failures:

Error: (rm43.sc) &rest cannot be used if the send target itself contains nested procedure calls or sends. Assign the result of the procedure call or send to a temporary variable and use that instead.  Line: 56, col: 27
Error: (Rock.sc) Duplicate label 'code_0448'  Line: 145, col: 0
Error: (Rock.sc) Duplicate label 'code_0453'  Line: 152, col: 0
Error: (RTRandCycle.sc) modeless is a property.  Only one parameter may be supplied.  Line: 525, col: 13
Error: (chAlloc.sc) The rest modifier must be followed by a parameter name.  Line: 32, col: 9
Error: (chAlloc.sc) The rest modifier must be followed by a parameter name.  Line: 46, col: 9
Error: (inputBox.sc) Undeclared identifier '--UNKNOWN-PROP-NAME--' .  Line: 1262, col: 32
Error: (inputBox_216.sc) Undeclared identifier '--UNKNOWN-PROP-NAME--' .  Line: 330, col: 32
Error: (rm330.sc) &rest cannot be used if the send target itself contains nested procedure calls or sends. Assign the result of the procedure call or send to a temporary variable and use that instead.  Line: 416, col: 29
Error: (rm330.sc) &rest cannot be used if the send target itself contains nested procedure calls or sends. Assign the result of the procedure call or send to a temporary variable and use that instead.  Line: 419, col: 29
Error: (rm330.sc) &rest cannot be used if the send target itself contains nested procedure calls or sends. Assign the result of the procedure call or send to a temporary variable and use that instead.  Line: 551, col: 29
Error: (rm330.sc) &rest cannot be used if the send target itself contains nested procedure calls or sends. Assign the result of the procedure call or send to a temporary variable and use that instead.  Line: 554, col: 29
Error: (rm330.sc) &rest cannot be used if the send target itself contains nested procedure calls or sends. Assign the result of the procedure call or send to a temporary variable and use that instead.  Line: 595, col: 29
Error: (rm330.sc) &rest cannot be used if the send target itself contains nested procedure calls or sends. Assign the result of the procedure call or send to a temporary variable and use that instead.  Line: 598, col: 29
Error: (rm330.sc) &rest cannot be used if the send target itself contains nested procedure calls or sends. Assign the result of the procedure call or send to a temporary variable and use that instead.  Line: 748, col: 29
Error: (rm330.sc) &rest cannot be used if the send target itself contains nested procedure calls or sends. Assign the result of the procedure call or send to a temporary variable and use that instead.  Line: 751, col: 29

Hi, I recently tried to open Kings Quest 5 (the Version with speech) and it as a very strange behaviour.
It seems to be a mixture of SCI 1.0 and SCI 1.1 (or in the transition phase) as it does support speech yet it only shows texts and no messages, probably due to the fact that it has a AUDIO001.MAP which presumably can not be proessed by SCICompanion?

As far as I know, speech was introduced with SCI 1.1 so I assume its one of the rare exceptions.

As you might know already I'm using it for translations and I can't get all dialog texts out of it using SCICompanion

Is there something that you can do?

As reported in icefallgames#22 , currently SciCompanion doesn't support QFG1VGA and PQ1VGA messages format.

Until it will be supported, is it possible to avoid saving modified messages? Instead, explain to the user that it's currently an unsupported feature.

Hi.
I've just decompiled QFG1VGA, and then recompiled Rock.sc (script 32) without changing anything, and it fails with:

Error: (Rock.sc) Duplicate label 'code_0448'  Line: 145, col: 0
Error: (Rock.sc) Duplicate label 'code_0453'  Line: 152, col: 0

I've checked Eric's decompilation repo, (it's called WizardGame.sc over there), and he just commented all that procedure. What's going on here?...

Thanks

Hi.

I'm trying to decompile GK1 with latest version (from Kawa's stash), and it crashes in the middle.
With older version it worked well.

Thanks.

SCICompanion version: 3.2.4

When a new room script is debugged and the default Ego is moved, the room crashes with the following message:

I don't know the nuts of bolts of the failure, but I do know why it crashes. The default new room script, calls the &getPolygon procedure ((gRoom addObstacle: (&getpoly {}))). This fetches the "empty string" polygon. However, a new pic has zero polygons by default. So the new room script tries to access a nonexistent polygon; thus, resulting in the crash. Correct or improve this explanation if needed.

The SCI compiler emits the following debug statement when accessing a nonexistent polygon: Unknown polygon name in &getpoly. This message is helpful, but the crash is frustrating when wanting to simply create a new room script and pic.

A possible solution is to comment out the getpoly procedure by default. A comment can be included to inform the user to uncomment the line once one or more polygon is added to the pic.

Furthermore, after the crash, when starting the game from the beginning, the following bug appears on the title screen:

I do not know what happens for these strange characters to appear in the title menu. Clicking on any of the options results in the following error:

Hi.
I've just decompiled QFG1VGA, and then recompiled chAlloc.sc (script 203) without changing anything, and it fails with:

Error: (chAlloc.sc) The rest modifier must be followed by a parameter name.  Line: 32, col: 9
Error: (chAlloc.sc) The rest modifier must be followed by a parameter name.  Line: 46, col: 9

Comparing to Eric's decompilation repo, it seems that these 2 dsCOORD should be replaced with 100.

Thanks

Hi,
when I try to edit messages and texts of the german version of SQ4 for example, umlauts are not displayed correctly:

In this example, expected would be "Natürlich bin ich mir sicher! Warum hätte ich es sonst ausgewählt"?

Would be nice if you could fix it.
Thanks