LSL3DEMO: Selectors are all zero about scicompanion

[Kawa-oneechan]

I fixed it! The whole thought process is on my twitter but here's the beef: https://twitter.com/NoxicoDev/status/1284492738831044613

And here's a direct link to today's build, with this fix included: http://helmet.kafuka.org/sci/SCICompanion.exe

[Kawa-oneechan]

The example I've been working with is (super init:) in room 200.

35 57            ldi 57
36               push 
39 00            pushi 0 // species
57 36 04         super Rm 4 

In DecompilerNew.cpp line 1507, it's supposed to return that 57, but it gives a 00 instead. In the real LSL3, I get 57 from this matching code:

39 57            pushi 57 // init
76               push0 
57 36 04         super Rm 4 

Notice how Companion's disassembler put a comment on pushi 0 in the demo, but on pushi 57 in the real game and not push0?

Clearly, the decompiler seems to prefer pushi for sends, but that's as far as I could get.

[Kawa-oneechan]

If I was bored enough, I'd go through what few non-system scripts there are and manually fix up the selectors myself.

[EricOakford]

As it turns out, the fix wasn't perfect. While many selectors are now correctly identified, there are still many more identified as species.

[Kawa-oneechan]

Well shit. Gonna look for "species" then, see what else is up.

[Kawa-oneechan]

Found it! pNodePrevious was set, but did not point to the LDI opcode I expected. So I changed the logic around a bit and now the only instances of species in my decompilation are in Obj::isKindOf and isMemberOf. As it should be.

Direct download in the same place as before.

[Kawa-oneechan]

@EricOakford, does it work?

[Kawa-oneechan]

I'm just going to assume it works then.