katosys / portus Goto Github PK

Is there a specific reason you chose to individually SED the env vars into the conf files?

I feel like the startup scripts would be easier to maintain if you used a tool like envsubts
https://www.gnu.org/software/gettext/manual/html_node/envsubst-Invocation.html

genuinely curious, I don't have a major preference either way.

I there any technical reason why you choose to create your own registry image?

Hey great work. Is there any plan for or some existing deployment/Helm chart for this to deploy on Kubernetes?

I propose that the without SSL configuration is exposed in the form of an environment variable.This is used when doing load balancing.

Could we please get a rebuild of this image pushed to Docker hub?

There have been some additions and fixes upstream that I think are pretty useful.

See:

• SUSE/Portus#1054
• SUSE/Portus#1017
• SUSE/Portus#1031

Perhaps a new image should be build whenever there is a commit upstream?

how can i use a public ip or domain?

Hi,

Portus' database needs to be provisioned I presume since it's complaining about the missing 'portus' user.

Also, when it tries to access to underlying registry, it cannot get the image hashes (401 authorization error).

I think the setup_databases() from compose-setup.sh needs to be integrated here also.

setup_database() {
  set +e

  TIMEOUT=90
  COUNT=0
  RETRY=1

  while [ $RETRY -ne 0 ]; do
    if [ "$COUNT" -ge "$TIMEOUT" ]; then
      printf " [FAIL]\n"
      echo "Timeout reached, exiting with error"
      exit 1
    fi
    echo "Waiting for mariadb to be ready in 5 seconds"
    sleep 5
    COUNT=$((COUNT+5))

    printf "Portus: configuring database..."
    docker-compose run --rm web rake db:migrate:reset > /dev/null
    docker-compose run --rm web rake db:seed > /dev/null

    RETRY=$?
    if [ $RETRY -ne 0 ]; then
        printf " failed, will retry\n"
    fi
  done
  printf " [SUCCESS]\n"
  set -e
}

you could simplify your image more. Environmental variables are not needed as Portus support them out of the box.

http://port.us.org/docs/Configuring-Portus.html#override-specific-configuration-options

I've been working with this for a while, and while it works nicely on localhost, I've noticed that it is not accessable form outside the server. I believe it may be due to the use of the --net flag which reverts all docker networking to the host. Is there a way to enable port forwarding to something other than localhost that I am missing? Thanks!

Error: registry does not implement v2 of the API. You can skip this check by clicking on the "Skip remote checks" checkbox.

If I skip remote checks, then portus doesn't appear to be communicating with the registry fully.

I can log in with the username and password that I create. I can push new images and get them back:

# curl -s 'https://portus-vagrant.mtnsat.io:5000/v2/_catalog'; echo

{"repositories":["admin/busybox"]}

But the image never shows up in the portus UI.

Hi,

I believe that besides dummy docs :) this is a very good starting point for Portus !!

One thing I can not get done automatically, is the crono startup.
I can start it manually after the portus container is up, but it would be nice to have this integrated into the image.

Kind regards, Tom