Build errors with MinGW, easy to fix but I'm not sure how to handle the #ifdef properly :/ about fake-08

[jtothebell]

I think#ifdef _WIN32 works, but I'm not familiar with building C/C++ on windows either. But looking at libretro code and a couple other projects, that looks like the right thing to do. At present I don't have a windows machine to check, but I did get the libretro core building on windows at one point and I think what you have described sounds like what I did.

[bslenul]

Yep all good now, both Libretro and standalone!

Thank you! ❤️

[bslenul]

Should I send a PR or you want to test for yourself first and/or find a better alternative maybe?

[jtothebell]

Found my old branch and pushed it. Does https://github.com/jtothebell/fake-08/tree/libretro-windows work for you? I got it building for someone else and they said it was working, but I don't know how thoroughly it was tested.

[bslenul]

#include <cstdint> (or <stdint.h>, idk the difference) required in this file: https://github.com/jtothebell/fake-08/blob/libretro-windows/platform/libretro/libretrohosthelpers.h but otherwise it builds and works fine for me now, yes 👍

edit: and putting that same #ifdef block inside https://github.com/jtothebell/fake-08/blob/libretro-windows/source/filehelpers.h let me build standalone as well, might want to add that too ;)

[jtothebell]

Alright, I moved that #ifdef block to host.h since mkdir should only be getting called from host implementations, and that should work for both libretro builds and standalone builds. If that is working, I'll merge that change in.

[jtothebell]

@bslenul Can you give me any more details about how you're building with MinGW for windows? I tried today to build the libretro core, and it builds fine, but crashes when I try to load a game (I don't see a smoking gun in the logs, but if I pepper some extra logging in it looks like its having trouble with the call to mkdir). I installed MSYS2 as recommended by the "Windows 7 and later compilation and development guide" in the libretro docs, then tried using MinGW-W64 and MinGW-W32 shells but the builds from both crash RetroArch.

The odd thing is that I have an old build from the branch I mentioned above on this same machine, and that one works still, but I can't remember what I might have done differently back then, so I was hoping you might be able to help. Thanks!

[bslenul]

I installed MSYS2 as recommended by the "Windows 7 and later compilation and development guide" in the libretro docs

Yeah I followed the same guide, then idk I didn't do anything special, just cd to platform/libretro/ then make and that's it.
Then in RetroArch: Main Menu > Load Content, select a .p8 file and it works just fine for me.

It seems to crash when loading the core without content however (so Main Menu > Load Core > FAKE-08 > Start Core), looks like it's because of info being NULL in retro_load_game(), it crashes here:

fake-08/platform/libretro/libretro.cpp

Line 621 in 46cdbcf

auto containingDir = getDirectory(info->path);

But in any case I don't seem to have any issue with mkdir anymore 🤔

[jtothebell]

@bslenul Well, I'm still not sure what is wrong with that windows machine, but I tried it on someone else's and it worked fine, so I set up a CI build in github actions and that output also seems to be working. I also threw in a quick fix to that crash. It just loads the cart list cart, which isn't really useful as configured, but at least it doesn't crash.