Coder Social home page Coder Social logo

Comments (5)

grzegorz-rozycki avatar grzegorz-rozycki commented on July 4, 2024 1

Same issue here. Instead of modifying the package I've overridden the newFormBuilder method.

<?php

namespace App;

use Illuminate\Database\Eloquent\Model;
use Nanigans\SingleTableInheritance\Exceptions\SingleTableInheritanceException;
use Nanigans\SingleTableInheritance\SingleTableInheritanceTrait;

class MyEloquentModel extends Model
{
    use SingleTableInheritanceTrait {
        newFromBuilder as private traitNewFromBuilder;
    }
    
    // ...

    public function newFromBuilder($attributes = array(), $connection = null) {
        try {
            return $this->traitNewFromBuilder($attributes, $connection);
        } catch (SingleTableInheritanceException $e) {
            return parent::newFromBuilder($attributes, $connection);
        }
    }
}

from single-table-inheritance.

jonspalmer avatar jonspalmer commented on July 4, 2024

A failing test case in a pull request would be helpful to track this down.

from single-table-inheritance.

00madz avatar 00madz commented on July 4, 2024

I ran into a similar issue when combining with the sluggable library trait. I ended up changing line 191:

throw new SingleTableInheritanceException("Cannot construct newFromBuilder without a value for $typeField");

To be:

return parent::newFromBuilder($attributes);

I guess on the assumption if you are dealing with a subset of fields you are probably not using full objects and base functionality is fine? I'm sure of the implications of doing this though, there are probably consequences

from single-table-inheritance.

nilay avatar nilay commented on July 4, 2024

I stuck with same issue and hoping next release will have the fix.

from single-table-inheritance.

jonspalmer avatar jonspalmer commented on July 4, 2024

Fixed.

from single-table-inheritance.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.