V0.8.6 causes incorrect attributes to be set about single-table-inheritance

[jonspalmer]

I've been able to track it down. Relatively simple fix coming soon.

…

On Thu, Mar 28, 2019 at 10:16 AM Stanislav Slow ***@***.***> wrote: Can confirm, I get the same behavior under laravel 5.5 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#60 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAUCIA9CHOXe6lnAGI5mv7sgyWmBhIpJks5vbM64gaJpZM4b5cQU> .

[jonspalmer]

This should now be fixed. Please checkout 0.8.7 and confirm

[jonspalmer]

Can you share code that demonstrates the problem or even better a failing test case?

[Levivb]

I'll check tomorrow if I can concoct an isolated example. If anything else, I could always include some screenshots from the debugger which might show the behaviour a bit better

[jonspalmer]

Screenshots from a debugger are unlikely to be of much help. Code examples or failing tests are considerably more helpful.

[sawisia]

I have a similar issue. fillable attributes for object are all null.

[jonspalmer]

Can you provide failing example test? Or code that demonstrates the problem?

…

On Wed, Mar 27, 2019, 3:08 PM sawisia ***@***.***> wrote: I have a similar issue. fillable attributes for object are all null. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#60 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAUCIEfJplKskFUoMp6GXkmigo72qci2ks5va8GagaJpZM4b5cQU> .

[Levivb]

Hey @bostanio

I've created a clean laravel 5.7 installation with a small poc sample.
See https://github.com/Levivb/single-table-inheritance-issue-60

Steps to reproduce:

1. clone repository https://github.com/Levivb/single-table-inheritance-issue-60
2. setup database
3. run art migrate:fresh; art db:seed
4. setup webserver to point to this repository
5. go to https://laravel.test for example You'll see two dumps, one with the queries ran and one with the collection of Things which have Vehicles eager loaded
6. Expand any Thing > relations > vehicles > items > 1 in the collection and note the vehicle (Car in this case) doesn't have any attributes
7. Now open app/Vehicle.php and enable the getPivotAttributeNames method
8. Refresh the page and expand the same Car in the relations of any Thing
9. Note how the attributes array of the Car now contains the fields of the Car record

[slowpokefarm]

Can confirm, I get the same behavior under laravel 5.5

[Levivb]

Confirmed 👍

[jonspalmer]

Awesome