Coder Social home page Coder Social logo

Event observers (created, deleting, etc) on the parent class don't get triggered for subclasses. about single-table-inheritance HOT 6 CLOSED

jonspalmer avatar jonspalmer commented on August 28, 2024 1
Event observers (created, deleting, etc) on the parent class don't get triggered for subclasses.

from single-table-inheritance.

Comments (6)

jonspalmer avatar jonspalmer commented on August 28, 2024

Can you provide a failing test case or better a PR?

from single-table-inheritance.

craigbartholomew avatar craigbartholomew commented on August 28, 2024

When observing the 'retrieved' event from my subclass, the event handler never gets called.

from single-table-inheritance.

craigbartholomew avatar craigbartholomew commented on August 28, 2024

In Eloquent's base Model class, the following line is called from the newFromBuilder method

$model->fireModelEvent('retrieved', false);

However, in the overridden method in SingleTableInheritanceTrait, the same event is never fired.

from single-table-inheritance.

jonspalmer avatar jonspalmer commented on August 28, 2024

Pull request happily considered. Sounds like it would be an easy fix.

from single-table-inheritance.

jonspalmer avatar jonspalmer commented on August 28, 2024

The original issue of created etc events is just how Eloquent works. You need to observe the events on subclasses individually. Nothing is different wit STI. The retrieved event is a real bug tracked separately as #58.

from single-table-inheritance.

tractorcow avatar tractorcow commented on August 28, 2024

I solved with with a custom observe method on STI models.

    public static function observe($classes): void
    {
        parent::observe($classes);

        // Note: Must apply to each subclass for STI classes
        foreach (static::getSingleTableTypeMap() as $typeClass) {
            /** @var static $typeClass */
            if (is_subclass_of($typeClass, static::class)) {
                $typeClass::observe($classes);
            }
        }
    }

from single-table-inheritance.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.