Comments (3)
I made the following, which seems to work:
class Base extends Model
{
public static function allQuery($columns = ['*'])
{
if (!in_array(static::class, static::$singleTableSubclasses)) {
$query = null;
foreach(static::$singleTableSubclasses as $subClass) {
if (is_null($query)) {
$query = static::where('type', $subClass::$singleTableType);
} else {
$query->orWhere('type', $subClass::$singleTableType);
}
}
return $query;
}
return static::where('type', static::$singleTableType);
}
public static function all($columns = ['*'])
{
return static::allQuery($columns)->get();
}
}
This allows you to do something like:
Base::all()
/*
\Collection {
all: [
\Sub { }
\SubAlt { }
]
}
*/
Sub::all()
/*
\Collection {
all: [
\Sub { }
]
}
*/
SubAlt::all()
/*
\Collection {
all: [
\SubAlt { }
]
}
*/
Believe this could be added to the trait itself and accomplish the same goal, but I'm not sure it's the most elegant solution.
from single-table-inheritance.
Second iteration:
- Uses DB.
- Allows columns specification.
- Cleaner implementation overall.
- Takes better advantage of developer settable properties.
public static function query($columns = ['*'])
{
$obj = new static();
$query = DB::table($obj->table)->select($columns);
if (in_array(static::class, static::$singleTableSubclasses)) {
$query = $query->where(static::$singleTableTypeField, static::$singleTableType);
}
return $query;
}
public static function all($columns = ['*'])
{
return static::query($columns)->get();
}
Going to be adding this to my own trait internal to my project. I have a mental note to submit a PR, but cannot promise timing and want to make sure I'm covering as many use cases as possible using my own project as the guinea pig first.
from single-table-inheritance.
I can't reproduce the error you describe and have added test that proves it works today dd0668b.
from single-table-inheritance.
Related Issues (20)
- "Field 'type' doesn't have a default value" when saving a model HOT 3
- Update Readme HOT 1
- One record two types. HOT 3
- Can we set the type of model using the base model? HOT 5
- hasMany relation doesn't work for parent class
- Can't create a new record directly form the base class HOT 10
- Broken link in README - Mark Smith's website is gone HOT 1
- Laravel 5.7 Support HOT 6
- Type is not inserted when using Laravel factories HOT 1
- Travis Builds are failing HOT 2
- Laravel 5.8 support
- Support the Eloquent `retrieved` event HOT 1
- Cannot insert record HOT 6
- V0.8.6 causes incorrect attributes to be set HOT 11
- Laravel 6.0 support HOT 1
- Eager loading child model relationship HOT 2
- Enhence performance when querying root model of subclasses HOT 5
- PHP hangs when parent and child inheritance is not setted properly. HOT 3
- `newFromBuilder` does not maintain mutated attributes HOT 2
- onlyTrashed()->forceDelete() seems to lose the SingleTableInheritance scope, deletes way more than intended HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from single-table-inheritance.