Coder Social home page Coder Social logo

Improve Typography about pixyll HOT 7 CLOSED

bandali0 avatar bandali0 commented on July 17, 2024
Improve Typography

from pixyll.

Comments (7)

johno avatar johno commented on July 17, 2024

That's awesome! I also think you're right on both fronts, we can fine tune the font size to be even better without a doubt.

  1. I think bringing down the font size from 1.5rem to 1.25rem should do the trick, yeah?
  2. Yeah, that's definitely, too big. Will have to done those down a few points. Likely 6rem => 4.5rem/4 => 3.25 on desktop/tablet.

Working on an update right now.

from pixyll.

johno avatar johno commented on July 17, 2024

@aminb just made some tweaks, let me know what you think.

from pixyll.

bandali0 avatar bandali0 commented on July 17, 2024

@johnotander looks much better :) I left a comment on one the lines of the commit.

I also suggest taking a look at Butterick’s Practical Typography if you haven't already, especially these 2 pages if you haven't got much time (although reading it would definitely be great):

from pixyll.

johno avatar johno commented on July 17, 2024

I'm inclined to agree with your 6rem line height.

Also, thanks for the links; I'll be sure to read those.

from pixyll.

bandali0 avatar bandali0 commented on July 17, 2024

@johnotander Awesome; later on, other headings should also be looked at and revisited to make sure they are all consistent and proportionate.

And, no problems 🍻

from pixyll.

johno avatar johno commented on July 17, 2024

Agreed, consistency is key. I will add an issue for now to ensure type scale consistency. #59

from pixyll.

bandali0 avatar bandali0 commented on July 17, 2024

πŸ‘

from pixyll.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.