Coder Social home page Coder Social logo

Comments (12)

nbro avatar nbro commented on August 15, 2024

Ok, I was clicking the wrong button to share on Facebook. I was using the button for Disqus. Anyway, I don't understand why we have this behaviour if we click on that button.

from pixyll.

ashawley avatar ashawley commented on August 15, 2024

I presume you uploaded the locally served files (jekyll serve) instead of the (jekyll build) files. The former contain references to "localhost" in the metadata used to share the page on Facebook, while the latter would contain the hosted location (assuming you set url correctly in your config).

If not, then it must be some defect with how the Facebook or Disqus code are interacting or some defect with how they're integrated in the theme.

from pixyll.

nbro avatar nbro commented on August 15, 2024

@ashawley How do I distinguish between locally served files and non-locally served? Locally, when I am writing the blog posts, I indeed locally test if the post is being displayed smoothly, but I don't actually know which files you're talking about.

from pixyll.

ashawley avatar ashawley commented on August 15, 2024

The files are generated in the _site directory. I'm assuming that's what you upload your site with. Is that how you publish your site?

from pixyll.

ashawley avatar ashawley commented on August 15, 2024

The port localhost:3000 is strange, because Jekyll usually uses localhost:4000. My theory was based on it being the Jekyll files served locally, but that was an oversight on my part. I'm not sure what's going on here.

from pixyll.

nbro avatar nbro commented on August 15, 2024

@ashawley I didn't upload any _site directory, actually. I only uploaded the _posts directory and other directories (_drafts, _includes, _layouts, _sass, css and `images).

from pixyll.

ashawley avatar ashawley commented on August 15, 2024

Yes, I don't think it has anything to do with how you built or uploaded the site.

I was able to reproduce the problem with the Disqus share to Facebook button. I couldn't figure out why it's doing that, though.

from pixyll.

galeone avatar galeone commented on August 15, 2024

Hi, I confirm this behavior. It also happens to me (and it's annoying, especially when people answer to a disqus message -> I receive the email -> the email contains the local IP I used to develop and test the website locally)

from pixyll.

ashawley avatar ashawley commented on August 15, 2024

the email contains the local IP I used to develop and test the website locally)

That's a different type of problem. I noted that it is localhost:3000, which is similar to localhost:4000 that Jekyll uses, but an actual numerical IP address sounds even odder.

from pixyll.

galeone avatar galeone commented on August 15, 2024

the email contains the local IP I used to develop and test the website locally)

That's a different type of problem. I noted that it is localhost:3000, which is similar to localhost:4000 that Jekyll uses, but an actual numerical IP address sounds even odder.

Yes it's really odd. Anyway, since I still have this problem (and so I guess all the people that comment on my blog have the same issue -> and this is awful since they can't reach the blog from the disus email), I attach some screenshot and some (I hope) helpful report.

So, for example, given the article: https://pgaleone.eu/tensorflow/bazel/abi/c++/2021/04/01/tensorflow-custom-ops-bazel-abi-compatibility/

I received the discus email that notifies me of some comment:

image

Every link that should point to my blog, points to http://127.0.0.1:4000/.

If I inspect with the developer tools the title link (Creating TensorFlow Custom Ops, Bazel, and ABI compatibility) in that email, I have this link:

<a href="http://disq.us/url?impression=74ac377c-947c-11eb-a96e-1292fcc87f23&amp;product=email&amp;object_type=thread&amp;variant=active&amp;forum_id=4662211&amp;utm_source=digest&amp;adjective=thread_title&amp;thread=8461061265&amp;verb=click&amp;event=activity&amp;threadrank=1&amp;user_id=228365963&amp;adverb=internal&amp;zone=digest&amp;url=http%3A%2F%2F127.0.0.1%3A4000%2Ftensorflow%2Fbazel%2Fabi%2Fc%2B%2B%2F2021%2F04%2F01%2Ftensorflow-custom-ops-bazel-abi-compatibility%2F%3A1rV5xCp3FM226NwtFszwc3Hx5v4&amp;object_id=&amp;experiment=new_notifications" style="color:#353a3d" target="_blank" data-saferedirecturl="https://www.google.com/url?q=http://disq.us/url?impression%3D74ac377c-947c-11eb-a96e-1292fcc87f23%26product%3Demail%26object_type%3Dthread%26variant%3Dactive%26forum_id%3D4662211%26utm_source%3Ddigest%26adjective%3Dthread_title%26thread%3D8461061265%26verb%3Dclick%26event%3Dactivity%26threadrank%3D1%26user_id%3D228365963%26adverb%3Dinternal%26zone%3Ddigest%26url%3Dhttp%253A%252F%252F127.0.0.1%253A4000%252Ftensorflow%252Fbazel%252Fabi%252Fc%252B%252B%252F2021%252F04%252F01%252Ftensorflow-custom-ops-bazel-abi-compatibility%252F%253A1rV5xCp3FM226NwtFszwc3Hx5v4%26object_id%3D%26experiment%3Dnew_notifications&amp;source=gmail&amp;ust=1618860065395000&amp;usg=AFQjCNGI8M9CAcerSdcZOBIg2_KCLrCi0w">
Creating TensorFlow Custom Ops, Bazel, and ABI compatibility
</a>

And that's the link:

http://disq.us/url?impression=74ac377c-947c-11eb-a96e-1292fcc87f23&amp;product=email&amp;object_type=thread&amp;variant=active&amp;forum_id=4662211&amp;utm_source=digest&amp;adjective=thread_title&amp;thread=8461061265&amp;verb=click&amp;event=activity&amp;threadrank=1&amp;user_id=228365963&amp;adverb=internal&amp;zone=digest&amp;url=http%3A%2F%2F127.0.0.1%3A4000%2Ftensorflow%2Fbazel%2Fabi%2Fc%2B%2B%2F2021%2F04%2F01%2Ftensorflow-custom-ops-bazel-abi-compatibility%2F%3A1rV5xCp3FM226NwtFszwc3Hx5v4&amp;object_id=&amp;experiment=new_notifications

The problem is in the "url" parameter that points to:

http%3A%2F%2F127.0.0.1%3A4000%2Ftensorflow%2Fbazel%2Fabi%2Fc%2B%2B%2F2021%2F04%2F01%2Ftensorflow-custom-ops-bazel-abi-compatibility%2F%3A

I have really no idea of what's going on.

from pixyll.

ashawley avatar ashawley commented on August 15, 2024

I wonder if this is the issue: Why are the wrong URLs detected for my discussions

Also, it seems like the embed code changed a long time ago:

https://blog.disqus.com/improve-your-disqus-integration-with-our-updated-embed-code

from pixyll.

ashawley avatar ashawley commented on August 15, 2024

If someone would be interested in updating the Disqus code snippet in Pixyll, see #439. It should probably be done, regardless, but we can see if that improves things or not for this issue.

from pixyll.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.