johngeorgewright / angular-xml Goto Github PK

Get ready for the imminent release of angular v1.2.0.

Response interceptors are deprecated!

But... it doesn't if i use the exact bower install like mentioned on the readme.
x2js seems to be installable by bower so i went with that, and that works.
Just thought i'd let you know.

The devDependency jasmine-core was updated from 3.4.0 to 3.5.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

jasmine-core is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

When using:
$httpProvider.interceptors.push('xmlHttpInterceptor');
it tries to convert the response even when it not a xml string anymore (and fails)

Example scenario, in the application an XML is received and transformed like:
transformResponse : function(data) {
return $.parseXML(data);
}
to a dom tree, to be used for xpath expressions.
In this scenario its not required for x2js to kick in and try to convert to json, since its not an xml string anymore

Hi! We've noticed a bug in the library that breaks the whole application when it occurs:

function responseIsXml(response) {
var contentType = response.headers('content-type'),
XML = '/xml',
minIndex = 'text/xml'.indexOf(XML);
return contentType.indexOf(XML) >= minIndex;
}

If for some reason content-type is not set, this fails with a "undefined exception".

Move the logic behind the XML parsing in to a separate service called XMLParser.

The devDependency nodemon was updated from 1.18.7 to 1.18.8.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

nodemon is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Get this on bower

While I'm parsing the Below XML i got error.

I am sure it isn't a common issue since I'm managing all of my 3rd party packages by using Grunt.

It was unable to detect the window object through the function argument "win", so I changed it to "window".

I am still fairly new to Angular so I am not sure if I am doing anything wrong, please let me know if I am missing something.

npm --version
1.4.16

sh: node_modules/grunt-protractor-runner/node_modules/.bin/webdriver-manager: No such file or directory
npm ERR! [email protected] postinstall: node_modules/grunt-protractor-runner/node_modules/.bin/webdriver-manager update
npm ERR! Exit status 127
npm ERR!
npm ERR! Failed at the [email protected] postinstall script.
npm ERR! This is most likely a problem with the angular-xml package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! node_modules/grunt-protractor-runner/node_modules/.bin/webdriver-manager update
npm ERR! You can get their info via:
npm ERR! npm owner ls angular-xml
npm ERR! There is likely additional logging output above.

Angular is now officially available as an npm module, tests should be able to use either.

Can you put an exmaple of what this config would look like? Or at least a unit test that I can refer to.

I try to get innerText of a node. anyone can help me? Thanks!

app.js

blogs.xml

The devDependency karma was updated from 3.1.0 to 3.1.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

karma is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency karma was updated from 3.1.1 to 3.1.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

karma is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Is it currently possible to specify an option or flag in $http.get() that sends JSON array requests as XML, or should I manually convert using x2js and then send?

The devDependency codecov was updated from 3.3.0 to 3.4.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

codecov is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Hi John,
Thanks for this useful tool.
The Content-type header can also contain optional parameters:
Content-Type: application/xml; charset=UTF-8
(see http://www.w3.org/Protocols/rfc1341/4_Content-Type.html )

The test for equality could be replaced with an indexOf:
contentType.indexOf('application/xml') === 0 || contentType.indexOf('text/xml') === 0

while I am working with angular routing, once I used $httpProvider.interceptors.push('xmlHttpInterceptor'); inside the config block, my routing is just left working. When I comment that line, it started to work again.

The documentation suggests the xmlFilter is going to return a ng.element object... but doesn't.

I've been putting it off for a while, but thinking maybe it would be a nicer option to use the x2js library. It adds dependencies, but it could make code a lot cleaner:

angular
  .module('myMode', ['xml'])
  .controller('Blogs', function ($scope, $http) {
    $scope.blogs = $http.get('/blogs.xml');
  });

Here's the branch

I get the XML similar to this from a wordpress 4 site.
I can parse all the items, but I cant get to the title and link and desc.

  <title>W3Schools Home Page</title>
  <link>http://www.w3schools.com</link>
  <description>Free web building tutorials</description>
  <item>
    <title>RSS Tutorial</title>
    <link>http://www.w3schools.com/rss</link>
    <description>New RSS tutorial on W3Schools</description>
  </item>
  <item>
    <title>XML Tutorial</title>
    <link>http://www.w3schools.com/xml</link>
    <description>New XML tutorial on W3Schools</description>
  </item>
</channel>

The devDependency nodemon was updated from 1.18.5 to 1.18.6.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

nodemon is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

I have tried to use your example and add elements to the xml like so:

For some reason I can only get to the first element doing this:

$http.get('view1/blogs.xml').success(function (data) {
$scope.blogs = data.blogs;
console.log($scope.blogs);
});

Is there a way to get it as an array of objects?

Would you mind uploading a quick XML example?

Thanks

The devDependency karma was updated from 4.1.0 to 4.2.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

karma is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency karma-firefox-launcher was updated from 1.1.0 to 1.2.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

karma-firefox-launcher is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency commitizen was updated from 3.0.4 to 3.0.5.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

commitizen is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Version 10 of Node.js (code name Dubnium) has been released! 🎊

To see what happens to your code in Node.js 10, Greenkeeper has created a branch with the following changes:

• Replaced the old Node.js version in your .nvmrc with the new one

If you’re interested in upgrading this repo to Node.js 10, you can open a PR with these changes. Please note that this issue is just intended as a friendly reminder and the PR as a possible starting point for getting your code running on Node.js 10.

Your Greenkeeper Bot 🌴

Doing my best to cut and paste your README code, I am stuck on

TypeError: Object [object Object] has no method 'attrs'
at http://localhost:8000/app/js/blogs.js:20:29

Nice project, works great reading my RSS feed.

However the project is missing an explicit license, perhaps you could add one?

Cheers,
Rob

Is there a way to specify which files to convert and which files to let through as is? Maybe the ability to add some req expressions to integrate the path and filename in the request?

The devDependency express was updated from 4.17.0 to 4.17.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

express is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

... what it says on the tin

The devDependency commitizen was updated from 3.1.1 to 3.1.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

commitizen is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency concurrently was updated from 4.1.0 to 4.1.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

concurrently is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

I found it useful to also intercept error responses, this way the server can send down xml data e.g. for a http 401 error response, see
https://github.com/trueqbit/angular-xml/commit/73715af0efaa36f5a3cf71cf7ed825c87fdb2ca8

Just started using the new version of angular-xml in a podcast application, where response headers are usually returned as text/xml;charset=UTF-8, but occasionally returned as application/rss+xml by certain feeds, such as: http://wtfpod.libsyn.com/rss.

I noticed that in the angular-xml.js file, whether or not a response is XML is determined by the following function:

function responseIsXml(response) {
    var contentType = response.headers('content-type'),
        XML = '/xml',
        minIndex = 'text/xml'.indexOf(XML);
    if (contentType) {
      return contentType.indexOf(XML) >= minIndex;
    } else {
      return false;
    }
  }

I've thought about making certain modifications to the functionality such as:

  function responseIsXml(response) {
    var contentType = response.headers('content-type');
    if (contentType) {
      return contentType.indexOf('xml') > -1;
    } else {
      return false;
    }
  }

but I do worry that this may result in some gotchas. Any thoughts?

Sometimes the content-type could be "text/xml".

I'm trying a single example structure (which contains $$hashKey as added by AngularJS during edit) and x2js.json2xml_str is producing a <$$hashKey>030</$$hashKey> node, which then the parser chokes on.
The end effect is that x2js.json2xml(myVar) is always null.
I would expect an exception not a null, but in this case I guess $-prefixed properties should simply be skipped, as they are both reserved in AngularJS and invalid XML tag names anyways.

Right now I'm doing this:

function removeDollars(obj) {
    if (typeof obj != 'object')
        return;
    for (var k in obj) {
        if (k.charAt(0) == '$')
            delete obj[k];
        removeDollars(obj[k]);
    }
}
var data = angular.copy($scope.value);
removeDollars(data);
var xml = x2js.json2xml_str(data);

Remove .gitignore, bower.json and README.md from the bower module.

The devDependency nodemon was updated from 1.19.0 to 1.19.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

nodemon is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴