Coder Social home page Coder Social logo

Comments (6)

rbsmidt avatar rbsmidt commented on June 21, 2024

Hi Pickled-plugins

I'm looking for the exact same in a project, that i'm working on. So yes - there's interest in such a feature, at least from me :-)

Other than that, i'm very pleased with classNames, so thanks to the author for a nice piece of work.

from classnames.

dcousens avatar dcousens commented on June 21, 2024

Why not just

classnames({
    'help': true,
    `help--${props.position}`: !!props.position
})

This would already work in ES6 AFAIK.

from classnames.

rbsmidt avatar rbsmidt commented on June 21, 2024

Might be a possibility - however i'm currently using JSX with watch-compiler but not ES6.
My issue is, that i want a category-label as a classname in addition to other dynamic classes (active-state e.g.). So what i want to do is:
var classes = classNames({ 'active': active, //where active is a bool {this.props.cat.slug}: true })

I'm still new to React, so maybe i'm trying to use the wrong tool for this operation, or maybe i just doesn't use it right. But if i try your suggestion, my JSX watch task gives me following error:

Parse Error: Line xxx: Unexpected token {

If i wrap the category slug ref in quotes, it obviously just treats my var ref as a string.
Am i trying to bend classNames in directions, that i shouldn't?

from classnames.

longlho avatar longlho commented on June 21, 2024

@rbsmidt you can read up on template string and have babel compiles your stuff

from classnames.

dcousens avatar dcousens commented on June 21, 2024

Closing, this is easily solved by just using ES6.
If you really need it, you can still solve the solution in a classical way.

No point special casing this library just for this.

from classnames.

peterszerzo avatar peterszerzo commented on June 21, 2024

@dcousens thank you for the tip. I did not know that interpolation worked for object keys, which makes your solution the best way to go.

from classnames.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.