Coder Social home page Coder Social logo

Comments (4)

jonkoops avatar jonkoops commented on July 4, 2024 2

Upon closer consideration, I do believe we could attempt to land this as a non-breaking change. Theoretically, if the exported surface is equivalent to that which is currently exposed, this should work as expected. I am going to give this a shot.

from classnames.

jonkoops avatar jonkoops commented on July 4, 2024 1

Yes, that is possible, but in practice I have had several bug reports on other packages I maintain when this field was introduced. Nothing wrong with putting this in a major version.

My intention is to try and fix all the existing open issues and then move to the tasks that would involve a potential major version bump such as this one.

from classnames.

jonkoops avatar jonkoops commented on July 4, 2024

I think this is a good idea, it's certainly where modern package development is going. In my experience applying this field it is a breaking change due to inconsistent behaviour of tools that consume it, so I will mark it as such.

from classnames.

krutoo avatar krutoo commented on July 4, 2024

@jonkoops i dont sure that is breaks packward compatibilty, you can add exports field like its done on react for example:

{
  "exports": {
    ".": {
      "default": "./index.js"
    },
    "./index.js": {
      "default": "./index.js"
    },
    "./bind": {
      "default": "./bind.js"
    },
    "./bind.js": {
      "default": "./bind.js"
    },
    "./dedupe": {
      "default": "./dedupe.js"
    },
    "./dedupe.js": {
      "default": "./dedupe.js"
    }
  },
}

if i properly understand

from classnames.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.