Comments (5)
Ok, sound like things work as expected in newer versions, so I will consider this resolved.
Correct, caused a bit of a headache. But at least if someone runs into this issue, they'll know :)
from classnames.
I suspect #301 might be the cause of this, but I am not sure. Can you share the minimal code needed to reproduce this? This includes bundler configuration and version information. Is there a specific version where this started breaking?
from classnames.
I might have found the cause. A dependency used v2.3.2, while the project uses v2.5.1.
Project which use v2.4 or higher and a dependency which uses v2.3.2 or lower causes some import issues
from classnames.
Ok, sound like things work as expected in newer versions, so I will consider this resolved.
from classnames.
I don't know if this is a problem with my configuration only but I've made sure I'm running 2.5.1 via the yarn lockfile and manual check in node_modules.
I'm using rollup (with only module support no commonjs) and i get this error message when i try to build, and it's pointing at the import of the classnames default export:
src/index.ts → dist/bundle.esm.js...
[!] RollupError: "default" is not exported by "node_modules/classnames/index.js", imported by "src/components/ActivityIndicator/ActivityIndicator.tsx".
My rollup config (rollup.config.mjs)
import typescript from '@rollup/plugin-typescript';
import sass from 'rollup-plugin-sass';
import resolve from '@rollup/plugin-node-resolve';
import peerDepsExternal from 'rollup-plugin-peer-deps-external';
import terser from '@rollup/plugin-terser';
export default {
input: 'src/index.ts', // Entry point for your library
output: [
{
file: 'dist/bundle.esm.js',
format: 'esm',
sourcemap: true,
},
],
plugins: [
peerDepsExternal(),
resolve(),
typescript({ tsconfig: './tsconfig.json' }),
sass({ insert: true }),
terser(),
],
external: ['react', 'react-dom'],
};
Any ideas to what could cause this? Or if anything else is needed to reproduce this issue?
My workaround for now is including a commonjs plugin for rollup and that solves the issue. But i feel like this is something others could encounter. This other issue #358 seems related.
from classnames.
Related Issues (20)
- Interface types aren't compatible in 2.3.2 HOT 4
- Throwing an exception when accessing non-existent classes HOT 2
- why not using one build tool for publish the npm package? HOT 2
- Incomplete type signature for classnames/bind HOT 2
- Advanced typing for classnames/bind HOT 4
- Explain to me about "cx" HOT 1
- Getting error says 'this' context of type 'void' is not assignable HOT 4
- [Question] When I used Object's value to computed key, what happened? HOT 2
- SyntaxError: Unexpected end of script (Mobile Safari) HOT 5
- When no classes are selected, classNames should return null HOT 5
- Vulnerable dependencies (indirect security issues) HOT 1
- How to erase or replace the properties of the conditional class from external component? HOT 1
- why number can be a className HOT 1
- Can we add exports field for this package? HOT 4
- Need a maintainer? HOT 7
- Preparing for version 3.0 HOT 9
- Should we support CommonJS for 3.0? HOT 5
- Import from 'classnames' broken since v2.5.0 HOT 5
- Please use GitHub Releases HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from classnames.