Coder Social home page Coder Social logo

Comments (4)

dcousens avatar dcousens commented on July 2, 2024

From my assessment, #21 is missing some edge cases because it doesn't split strings, so the following test would fail ...

That is what I found as well.
I think #21 is the best candidate, granted the tests could also be simplified.

As mentioned, we should pull the de-dupe implementation out to a separate file (dedupe.js) after merge.

from classnames.

JedWatson avatar JedWatson commented on July 2, 2024

PRs merged, ready to clean up and release.

from classnames.

JedWatson avatar JedWatson commented on July 2, 2024

Outstanding tasks to clean up dedupe:

  • wrap with IIFE so that utility variables and _parse function don't bleed into the global scope when the script is simply included in a page
  • move strict mode inside the IIFE so it doesn't affect other scripts when concatenated, ref https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode
  • use Array.isArray as per change in 2.0.0
  • should export classNames when used globally, it's a drop-in replacement for as per index.js

I'm on these now.

from classnames.

JedWatson avatar JedWatson commented on July 2, 2024

Just released 2.1.0 with this included.

from classnames.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.