Coder Social home page Coder Social logo

Comments (7)

dcousens avatar dcousens commented on July 20, 2024

@klimashkin you could also just do

object != null && object.constructor === Array

Which is 400% faster again. See https://jsperf.com/array-isarray-vs-instanceof-array/12

from classnames.

klimashkin avatar klimashkin commented on July 20, 2024

Yep, but it have a point if you check array.
If it is not array (and commonly we have no array as argument, more common are objects and booleans) faster to use Array.isArray
Because false.constructor === Array is actually means Object(false).constructor === Array

from classnames.

dcousens avatar dcousens commented on July 20, 2024

You're right, however if we just moved the else if (check if Array branch to be last, then it would be taking advantage of the fact that all other options failed, so the assumption that is an Array is therefore more likely.

from classnames.

klimashkin avatar klimashkin commented on July 20, 2024

But if we'll make array check the last, we should move check for object above, ie replace 'object' === typeof arg with Object.prototype.toString.call(arg) === '[object Object]' which is slower

from classnames.

dcousens avatar dcousens commented on July 20, 2024

from classnames.

stuartsan avatar stuartsan commented on July 20, 2024

Mentioned in #24 but also relevant here:

The issue with using instanceof Arrray or thing.constructor === Array is that it may fail when multiple frames are in use, because different frames' constructors have different identities, so frame 1's Array !== frame 2's Array.

from classnames.

dcousens avatar dcousens commented on July 20, 2024

Merged in #24

from classnames.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.