Coder Social home page Coder Social logo

Comments (8)

charkour avatar charkour commented on July 20, 2024 9

This is happening when using classnames with postcss modules.

I have something like this.

import s from './Button.module.css';
import cn from 'classnames';

    const rootClassName = cn(
        s.root,
        {
            [s.primary]: variant === 'primary',
            [s.secondary]: variant === 'secondary',
        },
        className
    );

If className is a string, then it is applied before the css modules with posts are applied, even though I specify that className should be the last thing applied in the function.


UPDATE

After using classnames and clsx for a year now, I believe the reason that className is applied after the CSS module is due to specificity. The CSS module has higher specificity than the className string passed to the cn().

from classnames.

Amberlamps avatar Amberlamps commented on July 20, 2024

Order is guaranteed: https://github.com/JedWatson/classnames/blob/master/index.js#L16
What kind of inconsistencies are you experiencing?

from classnames.

hyperh avatar hyperh commented on July 20, 2024

@Amberlamps It might have been a CSS modules composes issue actually. But thanks for the answer, at least I know that classnames guarantees class application order.

from classnames.

hosseinmd avatar hosseinmd commented on July 20, 2024

Order of class names is not correct.
Imagine we have this:
className='foo bar'

If we use this module there is a problem.
className= classNames('foo','bar') // return 'bar foo'

Class names should be reversed.

from classnames.

newyork-anthonyng avatar newyork-anthonyng commented on July 20, 2024

@hosseinmd can you provide an example of this?

https://codesandbox.io/s/vigilant-smoke-cnogr?file=/src/App.js

I created a codesandbox for this; it works as expected.

from classnames.

rodoabad avatar rodoabad commented on July 20, 2024

@charkour looks like order is not guaranteed based on your post.

from classnames.

charkour avatar charkour commented on July 20, 2024

Hey @rodoabad, thanks for your comment, but I'm not quite sure what you mean. Would you care to elaborate? Just so you know, I was able to solve the issue by learning how specificity works (which I had trouble comprehending before) and by finding a different workaround (we stopped using CSS modules).

After using classnames and clsx for a year now, I believe the reason that className is applied after the CSS module is due to specificity. The CSS module has higher specificity than the className string passed to the cn().

from classnames.

samerset-rmn avatar samerset-rmn commented on July 20, 2024

Hi there! Have you guys found any solution yet? I've just stumbled upon the same issue. Thinking how to prioritize the string classname over CSS module.

from classnames.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.