Coder Social home page Coder Social logo

Comments (5)

dcousens avatar dcousens commented on July 2, 2024

@bradleyayers I'm not opposed to the idea, its just a matter of the slippery slope.
Is there any reason why the DefinitelyTyped types wouldn't be suitable?

from classnames.

bradleyayers avatar bradleyayers commented on July 2, 2024

I went the DefinitelyTyped route initially, but hit a blocker because my project has two transitive dependencies on @types/classnames, which pulls in two sets of definitions that conflict (because they're global definitions).

I don't know of another solution here other than bundling the declaration files in the npm package.

from classnames.

dcousens avatar dcousens commented on July 2, 2024

@bradleyayers how will this solve that unless everyone uses this packages type definitions?

from classnames.

bradleyayers avatar bradleyayers commented on July 2, 2024

I'm not sure I understand the question, but…

TypeScript automatically uses type definitions that are bundled in NPM packages, but someone could still use @types/classnames if they want (but they probably wouldn't want to, since it's more overhead).

The key difference with packaged definitions is that they don't need to introduce definitions globally. This means that multiple instances of a package can be used at the same, each providing their own definitions.

from classnames.

dcousens avatar dcousens commented on July 2, 2024

Closing in favour of #103

from classnames.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.