Coder Social home page Coder Social logo

findroid's People

Contributors

6xingyv avatar adorjannm avatar alehaaaa avatar alison2033 avatar astrotheastronaut avatar cd16b avatar codename393 avatar decisoft avatar ido1990 avatar jarnedemeulemeester avatar jcuhfehl avatar kimpig avatar lsrom avatar lzyhenniu avatar mau671 avatar maugp551 avatar megumario avatar mrdog210 avatar natanel-shitrit avatar neropcstation avatar newton181 avatar nickskier avatar nukesource avatar pierreky-org avatar pysta avatar renovate[bot] avatar rogeriomendes avatar weblate avatar yash-garg avatar zan1456 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

findroid's Issues

Setting volume & brightness on screen

It would be great to be able to set the volume & brightness by "sliding" up or down on the screen.
Like the official app in fact, its a very useful features.

Thanks!

Missing Thumbnails

I've just installed the app and logged in my server. Everything is smooth as butter but there are no thumbnails. I restarted the app and waited 5-10 minutes with no changes.

Android: 7.1.2 (LineageOs 14)
device: Moto G

ps: it's awesome to be able to enjoy jellyfin on an older device, the native app is really slughish.

Error preparing player items

Screenshot_2021-08-21-10-17-41-360_dev jdtech jellyfin

This happened in some of the movie or TV shows. But some of those can play. I don't know what is the problem actually. Please help

Basic per Actor view

It would be nice to have a very simple list of movies and series the actor has appeared in upon clicking the actor picture. Maybe in the style of the current Episode Pop-up?

Add software decoding support

Even though ffmpeg support is present , i can confirm that currently there's no software decoding support in Exoplayer used by findroid . Hevc playback support isn't really great in my android device . Some hevc videos which are playable through hw decoding play well in findroid but the other ones simply fail to play . For reference , i can play all these videos through in Jellyfin official app with external player using software decoding . On top of that , Emby's Exoplayer has support for software decoding so all my videos play well there without any need of external players . I hope you could add this thing , its really useful & helps to avoid transcoding as much as possible. Eventually the player should play each video through hardware decoding at first & fallback to software decoding if the playback initially failed

Android 10
Findroid v0.1.2

Slight inconsistencies with the latest version (0.3.1)

Hello, I would like to share my experience with the latest version of Findroid (0.3.1)

  • The images of the episodes are not seen in the Downloads section.
  • When downloading any content starts, if it is cancelled, it still appears in the download section.
  • When you play something and you go to the phone screen and come back, the content doesn't continue, the app opens again.
  • When I select audio or subtitles while playing something, the android navigation bar appears and does not hide again, leaving the subtitles button behind.

If more information is required for the reproduction of any of these, I will gladly help.

Thank you very much for the good work.

Unify play media code

Currently there is identical code in EpisodeBottomSheetViewModel.createPlayerItems and MediaInfoViewModel.createPlayerItems. This should be moved to single implementation.

End of support?

It is a question since 12 days have passed since the last update. I know that perhaps programming an application like this is not an easy task but I would very much like a sign of life. Since I can not live without this application from the moment you took it out. I hope you can surprise us

State of home page not getting updated automatically

Describe the bug
Home page isn't getting automatically updated after watching show/movie, and there is no option to manually refresh it except switch tabs.

To Reproduce
Steps to reproduce the behavior:

  1. Watch something
  2. Exit to home
  3. Home page has outdated video position/old episode

Expected behavior
Home page is updated with new view position/next episode

Device info (please complete the following information):

  • Device: Poco X3 NFC
  • Android version: 11
  • App version: 0.2.1

External subtitles support

First thanks for this new app!

It seems external subtitles are not supported, it would be a great addition!

Thanks!

Move away from strings in conditions

This probably comes from Jellyfin SDK but they are trying to work on it as well. We should not use strings inside conditions and rather declare enums corresponding to SDK types and use those. For example item status (continuing/ended), item type (movie/series) etc.

Videos with a 4:3 aspect ratio incorrectly displaying thumbnail.

Describe the bug
Videos with a 4:3 aspect ratio incorrectly displaying thumbnail.
A

To Reproduce
Click on any unfinished show with a 4:3 aspect ratio and scroll down to the next up section.

Expected behavior
Thumbnail cropping as seen if you select the episode.
B

Device info

  • Android version: 11
  • App version: 0.2.1

No placeholder image for cast & crew

Findroid

C

Jellyfin

D

Having a solid color looks kinda weird imo, I think using or adding a placeholder image just like jellyfin would look nicer.

Save playback position in offline mode

When I use findroid in offline mode and stop the playback, it does not remember the playback position and jumps back to the last playback position stored in online mode.

Findroid should keep track of the playback positions when it is not connected to the server and ideally sync them back when reconnecting.

Display audio & subtitles title metadata if available

For example, I have lots of video with multiple audio channels in french (from France) and french (from Quebec). And they are both french and displayed like this.
However they have a title metadata specifying if they are french from France or french from Quebec.

Same for subtitles, I have some media with subtitles forced or full, and the only way to make the distinction is by their title.

So, if it's possible, it would be great to, if the title metadata is available, to display it.

Thanks!

Collections

No content, such as movies or shows, is displayed in collections, they are just empty.

Android: 11 (OneUi 3.1)

Subtitle issue

Describe the bug
A clear and concise description of what the bug is.

Either downloaded or subtitle on the media file of movie or show doesnt show on fritter player

To Reproduce
Steps to reproduce the behavior:

  1. Go to video
  2. Click on play
  3. Click on subtitle icon select subtitle
  4. No subtitle shows up .

Expected behavior
A clear and concise description of what you expected to happen.
Subtitle should show on all format of video
Screenshots
If applicable, add screenshots to help explain your problem.

Device info (please complete the following information):

  • Device: [e.g. Google Pixel 3]
  • Android version: [e.g. 12]
  • App version: [e.g. v0.1.1 (2)]

Additional context
Not all videos have this issue only few I believe which need software decoding also new subtitle downloaded doesnt show up from opensubtitle plugins on jellyfin as selection under subtitle

Small oddity in landscape mode

** Describe the issue **
The styling black thing surrounding the fanart isn't displayed properly in landscape mode, it cuts through the middle

** How to reproduce **
Simply go to a media info and go into landscape mode

** Screenshot **
Screenshot_20211001-040254_Findroid

** Additional info **
Is it because it is an ultrawide display ?

Love the app BTW, it's fairly easy to understand and very fast

No connection possible with Traefik 2.0 and http basic auth

Describe the bug
Using Traefik 2 setup as a reverse proxy with http basic auth for all connections, findroid can't connect.
The web interface works fine when using a browser.

To Reproduce
Setup Traefik proxy with http basic auth
Set hostname in app to the address
Press connect
See error "connection couldn't be established"

Expected behavior
The app to connect.

Logs

Screenshots

System (please complete the following information):
App version: v0.1.1
Android version: Android 11
Device manufacturer and model: Pixel 5
Jellyfin server version: 11.7.6
The type of video player implementation used: web player

Star Rating is shifted

Hi, so far i really like your app. I found a really minor issue though.
The Star Rating in the Episodes view is shifted and looks weird:
Screenshot_2021-08-22-12-02-15-25_aff99014c254344a005aaf8c1683039d.jpg

Looking forward to more great releases ๐Ÿ‘

Allow transcoding of multimedia content.

The ability to choose the quality of playback when choosing a movie or series is urgently needed.

I think this feature would be the most essential since it would be the first jellyfin client for android that allowed content transcoding. I AM GRATEFUL FOR YOUR WORK and I WOULD LIKE YOU TO INCLUDE IT AS SOON AS POSSIBLE.

I know we all have our lives and work, and you do too, but you have shown that you have done an excellent job creating this client. And I hope this client is the official Jellyfin for mobile needs. With this feature, the application would level up and be above EMBY.

Lack of spanish language

The app is entirely in English language. I can help you to translate the string.xml file to es, b+es+419 and es-rMX.

Steps to reproduce the behavior:

  1. Open application
  2. All the UI is in english

Expected behavior
The UI is in the native language of user.

Screenshots
No needed.

Device info (please complete the following information):

  • Device: moto G7 Play
  • Android version: Android 10
  • App version: v0.1.1

[suggestion] Redundant Item Details Header

image

The header on top would benefit from two tweaks:

  1. Remove the item name, as that info is already provided elegantly just below.
  2. Make the header bar either mostly or completely transparent so that the backdrop does not get cut off. In the above example, it's glaring.

I don't think the "home" and "my media" headers are necessary either, but that's minor.

Aspect ratio issue

Describe the bug
The aspect ratio seems to be different when compared to the official Jellyfin app, the content is not displayed over the punch-hole camera area.

To Reproduce
Steps to reproduce the behavior:

  1. Play video in a cinematic aspect ratio

Expected behavior
Video should cover the full screen, going over the punch-hole camera area.

Screenshots
Screenshot_20210825-171532
This is from the official app ^^

Screenshot_20210825-171656
Findroid here ^^

Device info (please complete the following information):

  • Device: Poco F3
  • Android version: 11
  • App version: v0.1.1 (2)

Media tab thumbnail

Describe the bug
Media tab thumbnail doesnt update

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Media'
  2. Check media and shows
  3. See error

Expected behavior
A clear and concise description of what you expected to happen.
I see thumbnail of show on movies and I have added new movie shows but there is no changes on media section even though on home page media as all updated contents
Screenshots
If applicable, add screenshots to help explain your problem.

Device info (please complete the following information):

  • Device: [e.g. Google Pixel 3]
  • Android version: [e.g. 12]
  • App version: [e.g. v0.1.1 (2)]

Additional context
Add any other context about the problem here.

Content aren't ordered by alphabetical number

** Describe the issue **
Content aren't ordered in alphabetical number

** How to reproduce **
Simply go to a library, TV Shows and Movies are concerned

** Screenshot **
Screenshot_20211001-124447_Findroid

** Additionnal info **
Might be due to the library size ? (600 movies)
I just modified the code to allow more items per row, 2 movies is a little for the size of my library, no other stuffs was modified

Audiobook support

First of, thanks for you app, stumbled upon it a few days ago and it's really great.

But I had one question, have you thoughts about audiobook support in the App?
The libraries are already shown in the app, but when clicking on a book entry, it only shows the title, a play button and the other (trailer, checkmark, heart) buttons. When clicking any of these, the app crashes, which is totally fine as its currently not implemented.

As you probably know, audiobook libraries have to be a "book"-type instead of music (which are not displayed at all, so music is out of scope for this app), so this would be a bit different than the movie/series libraries, but other than that it should be pretty similar, as audiobooks also have a checkmark for already watched episodes and a bookmark for the current progress of the episode, just like TV-Series.

What do you think about this? :)
Would be great to have a great looking one-stop app for Jellyfin to watch movies and also listen to audiobooks, as the current Jellyfin app is somewhat limited considering audiobooks, which you probably could do better as you are native

Sorry for this long text and thanks again

Edit: Just saw on my Homescreen on the bottom under "Latest Audiobooks" that there are single episodes of a series listed, so the app seems to be able to grab episodes and metadata from Jellyfin for audiobooks, so I guess it would just be a matter of adding the episodes to the Series listing and playing them?

Error loading data

No error thats the issue atleast a log file should be showing whats the issue on app end
Home page shows same error loading data

Loads fine on server end

Duplicate TV Shows entries

Describe the bug
In the TV Shows section of My media a TV Show can appear multiple times

To Reproduce
Steps to reproduce the behavior:

  1. Go to the TV Shows section in My media
  2. Look at list to find a TV Show with multiple seasons

Expected behavior
There should be a single entry for each TV Show.

Screenshots
Screenshot_20210825-181433
Official app ^^

Screenshot_20210825-180850
Findroid ^^

Device info (please complete the following information):

  • Device: Poco F3
  • Android version: 11
  • App version: v0.1.1 (2)

Fix live data usage

Currently view models have two live data variables for each value they pass to view. This is bad for several reasons:

  • readability
  • scalability
  • performance
  • error prone

This issue is actually two fold: First two LiveData instances per data item and second many LiveData streams carrying data. It would be best to pass State object from the view model which would hold all the values and if not possible then try to limit the number of streams as much as possible.

Disable subtitles

When I open an mkv that has a subtitle track with default set to true, findroid automatically enables it as expected. But I would like to disable this functionality, and never have subtitles automatically turned on, regardless of that flag. When I click the caption icon, I only have the options "Automatic" and "English" with no "None" option. I couldn't find anything relevant in the settings either.

Error playing with experimental MPV player

Describe the bug
The same update says so. The experimental MPV player is experimental. But almost nothing reproduces there. I know it is a good step to have a player with a lot of codec support but so far it is that, experimental. We greatly appreciate your dedication to this project. The new player interface is perfect. I know you will keep updating it and we look forward to more improvements and new features.

To Reproduce

  1. Activate the experimental player from the settings.
  2. Try to play content
  3. The screen goes into playback mode but the application closes automatically.

Device info:

  • Device: [LG K61]
  • Android version: [10]
  • App version: [0.2.0]

libVLC support

libVLC could be an option for SSA/ASS support while we wait (forever) for ExoPlayer to finally implement proper support for it. The Jellyfin Android TV app uses it and it works pretty well. It crashes occasionally, but overall its pretty good.

License dialog

Unfortunately, the Google Play OSS-Licenses library (com.google.android.gms.oss.licenses โ€“ always be wary if something starts with com.google.android.gms.) you use drags in non-free dependencies (it's well known for that) โ€“ here, Google Mobile Services (GMS). Maybe you'd consider replacing that with a true FOSS license dialog library? The four examples listed behind the link use either Apache-2.0 or MIT licenses, and thus should be compatible with your chosen GPL-3.0 (at least if you're talking "or later" โ€“ I'm not a license specialist, so I cannot say for absolutely sure).

Library Scanner results
Libraries detected:
-------------------
* Android Support v4 (/android/support/v4): Development Framework
* AndroidX Activity (/androidx/activity): Utility
* Android Jetpack Annotations (/androidx/annotation): Utility
* AppCompat (/androidx/appcompat): Utility
* Constraint Layout Library (/androidx/constraintlayout): Utility
* Androidx Core (/androidx/core): Utility
* Lifecycle (/androidx/lifecycle): Utility
* Media (/androidx/media): Utility
* Navigation (/androidx/navigation): Utility
* Preference (/androidx/preference): Utility
* Room (/androidx/room): Utility
* Android Activity Saved State (/androidx/savedstate): Utility
* Android Jetpack VersionedParcelable (/androidx/versionedparcelable): Utility
* AndroidX Widget ViewPager2 (/androidx/viewpager2): UI Component
* Glide (/com/bumptech/glide): Utility
* ExoPlayer (/com/google/android/exoplayer2): Utility
* Google Play OSS-Licenses (/com/google/android/gms/oss/licenses): UI Component
* Google Mobile Services (/com/google/android/gms): Development Framework NonFreeDep
* Google Material Design (/com/google/android/material): Utility
* OkHttp (/com/squareup/okhttp): Utility
* Dagger (/dagger): Utility
* Ktor (/io/ktor): Development Framework
* kotlinx.coroutines (/kotlinx/coroutines): Utility
Offending libs:
---------------
* Google Mobile Services (/com/google/android/gms): NonFreeDep

1 offenders.

By the screenshots, the app looks great! Looks like it's really time I give JellyFin a tryโ€ฆ

Library images are too big

It looks like libraries section is designed to fit only about 2 items, but some people have more than 2 libraries to separate languages and other stuff.
Please add option for different display design or shrink the items?
image

Download Restriction

Currently, app is ignoring "Allow media downloads" option from the jellyfin server. it let all users download media.

Show search button on every page

Its kinda annoying to only have the search button on the library page. Having it on all the pages would be nice.
I feel like this could also apply to the settings button.

Support movie logos

One of my favorite bits of the normal jellyfin app is that you can skin it with css, including changing out the title on the movie page for it's logo image. I think this would be a great option to add to findroid.

Support paging when loading media items

Right now we use items API just to get all items matching our specified parameters but that can be hundreds or thousands of items. For example, LibraryFragment can load entire movie collection which might be massive for some users.

Luckily Jellyfin enables us to use startIndex and limit parameters to specify how much items we want and from what offset. I suggest we use this to load items in smaller batches.

Goal

Can't add server on local network

Its possible I've not put in the right format, but I've tried every format I can think of (maybe a hint can be added to the login screen).

Any ideas? The regular Jellyfin app finds the server with no issue so I presume that's all configured correctly.

add pinch to zoom

Many phones have 19:8, 21:8 ratio so it would be good to add this

Screen lock

First of all, great job with the app!

It would be nice to be able to lock the screen the exact same way as the Netflix Android app.

Hopefully not something too troublesome to implement. Sometimes my kid watches videos on my phone but not being able to lock the screen can cause problems.

Transparent subtitles background

Could you please add an option for transparent subtitles background? I find the black background slightly annoying, blocking more parts of the image than needed.

Book media libraries

...are displayed on the home screen. I don't think they're in the scope of this app so this type of media should likely be hidden away just like music is.

Add STRM support

Describe the bug
Looking to add support for STRM files. Jellyfin server supports them already, it just requires passing the particular URL into exoplayer. I can give you a STRM file to test, or I can make a test account if you would like.

FEATURE REQUEST Android TV

Hi please could you make this client for Android TV I love how fast this client is, it's unbeatable

So again Please for Android TV

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.