Coder Social home page Coder Social logo

License dialog about findroid HOT 15 CLOSED

IzzySoft avatar IzzySoft commented on May 27, 2024 1
License dialog

from findroid.

Comments (15)

dkanada avatar dkanada commented on May 27, 2024 4

We have a native casting feature as well! Any client can implement Jellyfin's flavor of casting for remote control support in both directions. I always thought it was a hugely undervalued feature, even though it's a bit unpolished right now on the web clients.

from findroid.

jarnedemeulemeester avatar jarnedemeulemeester commented on May 27, 2024 2

Oh I didn't know that, thanks!
I will replace that library with one of the four examples you listed.

I want to implement Chromecast support later down the road. And that also requires GMS.
Maybe when I do implement that, I can make two versions. One with non-free deps and one without, for the Google Play Store and F-Droid respectively.
Because I do think that a lot of people would also like casting support.

from findroid.

IzzySoft avatar IzzySoft commented on May 27, 2024 2

I will replace that library with one of the four examples you listed.

Great! Then it will qualify for F-Droid.

I want to implement Chromecast support later

Ugh. Hard decision: features versus FOSS. If you really want to do that (again tainting your nice FOSS apps with proprietary things), consider to use a separate build flavor at least – so there can still be a FOSS build by e.g. F-Droid.

Maybe when I do implement that, I can make two versions. One with non-free deps and one without, for the Google Play Store and F-Droid respectively.

Exactly. I just wonder if "casting support" automatically means "Chromecast" – or whether there are other means. Jellyfin also supports DLNA, so why not integrating a "DLNA control point"/server instead? A server would show up on other devices, a control point can be used to tell a client what to play (basically, it could act as a mediator, like telling your TV to play that specific movie from your Jellyfin instance). AFAIK "Casting" you'd only need if you wanted to share your screen contents e.g. to a TV. As most multimedia devices support DLNA (to my knowledge, even more than support Chromecast/Miracast), DLNA would be the better way to go. And remain FOSS 😉

from findroid.

jarnedemeulemeester avatar jarnedemeulemeester commented on May 27, 2024 2

Oh yeah I totally forgot about that. That's probably the way to go. I'll add it to the list of stuff I need to investigate.

Feel free to open a new issue for Jellyfin's casting support, let's keep this issue about the license dialog.
I should definitely setup a feature requests platform instead of relying on GitHub issues for features 😄

from findroid.

jarnedemeulemeester avatar jarnedemeulemeester commented on May 27, 2024 2

@IzzySoft done!

from findroid.

jarnedemeulemeester avatar jarnedemeulemeester commented on May 27, 2024 1

I will provide a build for armeabi-v7 with the next release. That should reduce the size a lot.
Maybe I will also create one for the current release. If I do I will let you know

from findroid.

IzzySoft avatar IzzySoft commented on May 27, 2024

Thanks for chiming in, @dkanada! – @jarnedemeulemeester maybe that's the way to go then, for a proper Jellyfin client, wouldn't you agree? 😃

from findroid.

IzzySoft avatar IzzySoft commented on May 27, 2024

Cool – thanks a lot! Looking forward to the next release, where I can drop the NonFreeDep.

Oh: maybe you want to complement that Google Play badge by this one, pointing to your app here, @jarnedemeulemeester?

from findroid.

IzzySoft avatar IzzySoft commented on May 27, 2024

😍 That badge looks really nice there 😄 And the listing much better without that AntiFeature banner (with the next sync tomorrow – sorry for the delay, I was quite busy with my dayjob today). Thanks a lot!

from findroid.

IzzySoft avatar IzzySoft commented on May 27, 2024

@jarnedemeulemeester APK size just exploded with the last 2 versions: from 10 MB to over 100 MB. That's far too much for my repo, which has a limit of 30 MB per app.

To mitigate the issue, could you please provide a per-ABI build for armeabi-v7 (which covers about 90%+ of all Android devices)? That will probably be around 30..40 MB, considering you currently include 4 architectures. If you can strip down APK size by other means, I'm of course open to alternatives. But I cannot keep it at its current size, sorry. Once Jellybean arrives at F-Droid.org, that's an entirely different case.

from findroid.

IzzySoft avatar IzzySoft commented on May 27, 2024

Great, thanks a lot! And yes, please let me know when it's there so I can adjust the config here (to tell the updater which one to pick).

from findroid.

jarnedemeulemeester avatar jarnedemeulemeester commented on May 27, 2024

@IzzySoft I have released a new version with per-ABI builds. The size is around 30MB.
I will make an effort to reduce the size in the next update.

from findroid.

IzzySoft avatar IzzySoft commented on May 27, 2024

Thanks! Nice XMas present 😄 Updated the YAML here (wish you had told me in advance, the updater meanwhile hat picked the x86 APK – had to replace it by the ARM one manually. With x86 being not that present on devices, not too many users should have been affected, though). Updater will now grab the armeabi variant.

And yes, please keep me updated. Should you manage to reduce the size to below 20M (unlikely, but who knows) I could allow to keep 2 versions.

Besides: are you interested in having Fastlane structures established? I could send you an initial setup as PR. Multiple advantages with that:

  • you can maintain yourself how your app is presented to the user
  • updates would be pulled along with releases, so they would stay in sync
  • you could even provide per-release changelogs shown along with the app description (optional of course)

Just let me know if you'd like that PR.

from findroid.

jarnedemeulemeester avatar jarnedemeulemeester commented on May 27, 2024

Hi @IzzySoft
The next release will be a bit bigger than 30MB. This is because I now include all codecs in the mpv (FFmpeg) library included in the app.
Don't worry if you can't publish the app in your repo, I am working towards releasing in on F-Droid.

The main issue I'm am still stuck with is the included binary .aar libraries, F-Droid doesn't allow those. I already migrated one of the two included libraries to their own repo and uploaded it to Maven central. But I am having trouble building the second library for inclusion in Maven central. So the next version (v0.9.0) won't be available on F-Droid yet.

PS I will also be looking at Fastlane when I do get that binary library out of this repo.

from findroid.

IzzySoft avatar IzzySoft commented on May 27, 2024

Thanks for the warning, @jarnedemeulemeester – I'll won't reject that update right away then (30 M is no hard limit; there's some 32 M limit with one of the APIs I use, but if needed I can work around that – though I prefer to keep the number of apps I need to do that as low as possible).

Great you're working on F-Droid inclusion. Best luck for that last remaining AAR! Need to look which one it is; if ffmpeg-android-maker would work, I'd know how it could be included at F-Droid (there's a srclib set up for that which builds the dependency in preparation for the app build, can be configured with the *.yml of the app).

from findroid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.