Comments (5)
Hi Adam,
I agree this should be an option. Not sure why I did it that way.
Will definitely merge if you want to make a pull request -- otherwise I should be able to add it in this weekend 👍
from bigpicture.
Merged pull request #28
from bigpicture.
🎉
Just for a bit of feedback, I've noticed the simplification to position || 0
and such — I used the more complicated version for cases if you for instance had a HTML like:
<div>
<h2>Whatever</h2>
<a>Link (position: 0, but gets overwritten by indexEl: 1)
</div>
That was probably overly complicated, is that right?
from bigpicture.
(specifically the second part of makeGallery
— I just realized that the array
part would come out to 0 || 0
anyway)
from bigpicture.
Ah, you're totally right. I was trying to save a few bytes didn't catch that a positive element index would take if someone was trying to pass in position 0 for a non-array.
I'm going to restore your line to how it was. Sorry about that! 🤦♂️
from bigpicture.
Related Issues (20)
- dimensions not working for <video> HOT 3
- Feature request. support for responsive images by using srcset attribute HOT 1
- Destroy BigPicture HOT 2
- Add support for start time for YouTube videos HOT 1
- Feature request. Make use of youtube nocookie domain. HOT 2
- Content Security Error - refused to evaluate string HOT 2
- Es6 modules HOT 1
- Separate scripts for video demos HOT 3
- Feature request: Option to pass controlslist value to HTML Video HOT 2
- Feature request: add swipe support HOT 3
- Feature request: support pinch zoom in/out HOT 1
- Full screen button on Vimeo player not working when browser is full screen HOT 1
- Feature request - support for iframes with variable height HOT 8
- Feature request: Publish 2.6.0 to npm HOT 1
- Feature request : control the video looping HOT 6
- Feature Request: Fill screen HOT 3
- Youtube videos start in lower quality HOT 9
- HLS Support? HOT 1
- If ytNoCookie is true, YouTube video will not autoplay in Safari HOT 2
- Implement on plain-Jane, non-framework, basic HTML/JS/CSS pages HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bigpicture.