Coder Social home page Coder Social logo

Comments (5)

henrygd avatar henrygd commented on August 16, 2024

Hi Adam,

I agree this should be an option. Not sure why I did it that way.

Will definitely merge if you want to make a pull request -- otherwise I should be able to add it in this weekend 👍

from bigpicture.

henrygd avatar henrygd commented on August 16, 2024

Merged pull request #28

from bigpicture.

adamkiss avatar adamkiss commented on August 16, 2024

🎉

Just for a bit of feedback, I've noticed the simplification to position || 0 and such — I used the more complicated version for cases if you for instance had a HTML like:

<div>
  <h2>Whatever</h2>
  <a>Link (position: 0, but gets overwritten by indexEl: 1)
</div>

That was probably overly complicated, is that right?

from bigpicture.

adamkiss avatar adamkiss commented on August 16, 2024

(specifically the second part of makeGallery — I just realized that the array part would come out to 0 || 0 anyway)

from bigpicture.

henrygd avatar henrygd commented on August 16, 2024

Ah, you're totally right. I was trying to save a few bytes didn't catch that a positive element index would take if someone was trying to pass in position 0 for a non-array.

I'm going to restore your line to how it was. Sorry about that! 🤦‍♂️

from bigpicture.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.