Comments (3)
The dimensions are only for iframe elements. So iframeSrc
, ytSrc
, and vimeoSrc
. The readme is a bit of a mess at the moment so I understand the confusion.
For videos, you can use CSS to make them a certain width:
#bp_vid {
width: 640px;
}
Would that solve your use case?
from bigpicture.
Yes right I could simply use that CSS.
Well there is not really something to "solve". I already solved it for myself in that way but not really liked it.
For my case I want to set it from JS because I have to set it for iframes via dimensions anyway. So I thought for consistency it should work for video as well and along the way I figured its probably best to only set the style.width
for the <video>
. So you could take only the width from dimensions and set that on <video>
s. Also a bit weird maybe, I don't know. Feel free to close.
from bigpicture.
Went ahead and added this in 2.5.1
from bigpicture.
Related Issues (20)
- Feature request. support for responsive images by using srcset attribute HOT 1
- Destroy BigPicture HOT 2
- Add support for start time for YouTube videos HOT 1
- Feature request. Make use of youtube nocookie domain. HOT 2
- Content Security Error - refused to evaluate string HOT 2
- Es6 modules HOT 1
- Separate scripts for video demos HOT 3
- Feature request: Option to pass controlslist value to HTML Video HOT 2
- Feature request: add swipe support HOT 3
- Feature request: support pinch zoom in/out HOT 1
- Full screen button on Vimeo player not working when browser is full screen HOT 1
- Feature request - support for iframes with variable height HOT 8
- Feature request: Publish 2.6.0 to npm HOT 1
- Feature request : control the video looping HOT 6
- Feature Request: Fill screen HOT 3
- Youtube videos start in lower quality HOT 9
- HLS Support? HOT 1
- If ytNoCookie is true, YouTube video will not autoplay in Safari HOT 2
- Implement on plain-Jane, non-framework, basic HTML/JS/CSS pages HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.