Coder Social home page Coder Social logo

Comments (3)

henrygd avatar henrygd commented on August 16, 2024

The dimensions are only for iframe elements. So iframeSrc, ytSrc, and vimeoSrc. The readme is a bit of a mess at the moment so I understand the confusion.

For videos, you can use CSS to make them a certain width:

#bp_vid {
  width: 640px;
}

Would that solve your use case?

from bigpicture.

nextgenthemes avatar nextgenthemes commented on August 16, 2024

Yes right I could simply use that CSS.

Well there is not really something to "solve". I already solved it for myself in that way but not really liked it.

For my case I want to set it from JS because I have to set it for iframes via dimensions anyway. So I thought for consistency it should work for video as well and along the way I figured its probably best to only set the style.width for the <video>. So you could take only the width from dimensions and set that on <video>s. Also a bit weird maybe, I don't know. Feel free to close.

from bigpicture.

henrygd avatar henrygd commented on August 16, 2024

Went ahead and added this in 2.5.1

from bigpicture.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.