Comments (3)
I'd be happy to help you figure it out. Can you post a snippet of your code, or make an example on codepen or codesandbox?
from bigpicture.
I'd be happy to help you figure it out. Can you post a snippet of your code, or make an example on codepen or codesandbox?
Here is link of code - https://codesandbox.io/s/bigpicturejs-demos-utx4u?file=/index.html
I tried this one with youtube-video
this running well at first view, but after i add svg icon to the button, after refresh it didn't work again and showing the same issue - Error: The requested image could not be loaded.
Thanks for your time.
and Thanks too for awesome & cool lightbox plugin.. Keep it up..
I also love your another script side-panel like thing. really cool and lightweight, will use it also in near future..
Keep it on brother. but make it little easier to get done with demos for average JS users like me
from bigpicture.
No problem! You can make it work by changing e.target
to e.currentTarget
like this:
BigPicture({
el: e.currentTarget,
ytSrc: e.currentTarget.getAttribute("ytSrc")
});
After you put the svg inside the button, e.target becomes the svg when it's clicked (it's the element you clicked to trigger the event). e.currentTarget
is always the button even when an element inside is clicked (because it's what you assigned the event listener to). It was failing because the svg does not have the ytSrc
attribute.
Here's the working code: https://codesandbox.io/s/bigpicturejs-demos-forked-mwvtq?file=/index.html:3391-3525
I'm going to close this issue, but feel free to follow up with any question or comment.
from bigpicture.
Related Issues (20)
- Not work multiple ( HOT 1
- Feature request? Can I programmatically close the lightbox? HOT 3
- dimensions not working for <video> HOT 3
- Feature request. support for responsive images by using srcset attribute HOT 1
- Destroy BigPicture HOT 2
- Add support for start time for YouTube videos HOT 1
- Feature request. Make use of youtube nocookie domain. HOT 2
- Content Security Error - refused to evaluate string HOT 2
- Es6 modules HOT 1
- Feature request: Option to pass controlslist value to HTML Video HOT 2
- Feature request: add swipe support HOT 3
- Feature request: support pinch zoom in/out HOT 1
- Full screen button on Vimeo player not working when browser is full screen HOT 1
- Feature request - support for iframes with variable height HOT 8
- Feature request: Publish 2.6.0 to npm HOT 1
- Feature request : control the video looping HOT 6
- Feature Request: Fill screen HOT 3
- Youtube videos start in lower quality HOT 9
- HLS Support? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bigpicture.