Comments (7)
Hey @henrygd I took some time to test the audio feature and it is working like a charm, nice job, now I think this library is media complete ;-) thanks for the so quick turn around on this. I will be using it in my project https://spry.cr
from bigpicture.
No but here's a version that supports audio (tested only on chrome and firefox):
https://codesandbox.io/s/k57433qyv
from bigpicture.
Hi @henrygd , is there a possibility that audio can be supported in the core, or is there any reason you didn't add audio ? I have a use case at my company were an mp4 can be just audio file, in that case it would be very useful to just load it using this same library.
BTW. The audio files are loading with the audio look and field already so I am not sure this is a fallback behavior of the html5 video tag, which is so cool, but I am not sure if all browser has this same behavior so it would be great if it this can be officially supported by this lib.
Thanks!
from bigpicture.
@cayasso Sure, I'll try to add an audio option this weekend.
In your case do you know ahead of time which mp4 files are meant as audio and which are video?
from bigpicture.
Should have this updated in the next couple of days. Safari is acting weird in browserstack so I need to test on my computer at work.
from bigpicture.
So awesome! thank you for be adding this feature @henrygd.
To your question above, yes I know ahead of time which is audio and which is going to be a video with a flag, I am not sure if there is a way to do this programmatically but for sure crome seems to know when its only audio or video+audio.
from bigpicture.
Finally got this sorted: e1813be
@cayasso Let me know if you have any trouble
from bigpicture.
Related Issues (20)
- dimensions not working for <video> HOT 3
- Feature request. support for responsive images by using srcset attribute HOT 1
- Destroy BigPicture HOT 2
- Add support for start time for YouTube videos HOT 1
- Feature request. Make use of youtube nocookie domain. HOT 2
- Content Security Error - refused to evaluate string HOT 2
- Es6 modules HOT 1
- Separate scripts for video demos HOT 3
- Feature request: Option to pass controlslist value to HTML Video HOT 2
- Feature request: add swipe support HOT 3
- Feature request: support pinch zoom in/out HOT 1
- Full screen button on Vimeo player not working when browser is full screen HOT 1
- Feature request - support for iframes with variable height HOT 8
- Feature request: Publish 2.6.0 to npm HOT 1
- Feature request : control the video looping HOT 6
- Feature Request: Fill screen HOT 3
- Youtube videos start in lower quality HOT 9
- HLS Support? HOT 1
- If ytNoCookie is true, YouTube video will not autoplay in Safari HOT 2
- Implement on plain-Jane, non-framework, basic HTML/JS/CSS pages HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bigpicture.